diff options
author | Bruce Mitchener <bruce.mitchener@gmail.com> | 2013-12-11 20:36:06 +0700 |
---|---|---|
committer | Bruce Mitchener <bruce.mitchener@gmail.com> | 2014-01-13 17:59:15 +0700 |
commit | 369b8330ed5e115be82b616414892aaf1e3c7b2c (patch) | |
tree | 0cd4fed3933a2b14f768b5c765264b9cb1009b3d /src | |
parent | 4353f5df1e4bae2a3d579a5c205b800bcc2d8d39 (diff) |
Handle negative zero values correctly.
This handles the situation when they're part of a global variable
whether it just be a float/double or embedded within a struct.
Fixes #1898.
Diffstat (limited to 'src')
-rw-r--r-- | src/jsifier.js | 3 | ||||
-rw-r--r-- | src/parseTools.js | 7 |
2 files changed, 9 insertions, 1 deletions
diff --git a/src/jsifier.js b/src/jsifier.js index a503e90d..726a5eda 100644 --- a/src/jsifier.js +++ b/src/jsifier.js @@ -215,6 +215,9 @@ function JSify(data, functionsOnly) { function parseConst(value, type, ident) { var constant = makeConst(value, type); + // Sadly, we've thrown away type information in makeConst, so we're not + // passing correct type info to parseNumerical which works around this + // lack. constant = flatten(constant).map(function(x) { return parseNumerical(x) }) return constant; } diff --git a/src/parseTools.js b/src/parseTools.js index 4d6d7bd3..b7f97a40 100644 --- a/src/parseTools.js +++ b/src/parseTools.js @@ -962,8 +962,13 @@ function parseNumerical(value, type) { } if (isNumber(value)) { var ret = parseFloat(value); // will change e.g. 5.000000e+01 to 50 + // type may be undefined here, like when this is called from makeConst with a single argument. + // but if it is a number, then we can safely assume that this should handle negative zeros + // correctly. + if (type === undefined || type === 'double' || type === 'float') { + if (value[0] === '-' && ret === 0) { return '-.0'; } // fix negative 0, toString makes it 0 + } if (type === 'double' || type === 'float') { - if (value[0] === '-' && ret === 0) return '-.0'; // fix negative 0, toString makes it 0 if (!RUNNING_JS_OPTS) ret = asmEnsureFloat(ret, type); } return ret.toString(); |