diff options
author | Alon Zakai <alonzakai@gmail.com> | 2011-12-07 11:24:09 -0800 |
---|---|---|
committer | Alon Zakai <alonzakai@gmail.com> | 2011-12-07 11:24:09 -0800 |
commit | ac5c48218d97222a6e18aa3341f16507766596bd (patch) | |
tree | 8f583cf3778b7792eed9de0353f12f3c58ac7e1f /src/runtime.js | |
parent | e702f719f832582fb6b1864115bb7a8526148574 (diff) |
parseInt test is problematic, mark it as such, and fix some i64 issues with rounding (but not all)
Diffstat (limited to 'src/runtime.js')
-rw-r--r-- | src/runtime.js | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/src/runtime.js b/src/runtime.js index 637632f8..0b36f967 100644 --- a/src/runtime.js +++ b/src/runtime.js @@ -305,6 +305,8 @@ function reSign(value, bits, ignore, sig) { var noted = false; #endif if (value >= half && (bits <= 32 || value > half)) { // for huge values, we can hit the precision limit and always get true here. so don't do that + // but, in general there is no perfect solution here. With 64-bit ints, we get rounding and errors + // TODO: In i64 mode 1, resign the two parts separately and safely #if CHECK_SIGNS if (!ignore) { CorrectionsMonitor.note('ReSign', 0, sig); |