aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAlon Zakai <alonzakai@gmail.com>2013-01-23 16:48:49 -0800
committerAlon Zakai <alonzakai@gmail.com>2013-01-23 16:48:49 -0800
commitf23a99a624e51acacb7d38f0e70b2bb12aaf5e73 (patch)
tree455d4099986376b8948e675e16bb477fcf7fd9f5
parentab20c69e046731f722f39016539dc1ffe4040aa1 (diff)
fix isNaN for asm
-rwxr-xr-xemscripten.py2
-rw-r--r--src/parseTools.js9
2 files changed, 8 insertions, 3 deletions
diff --git a/emscripten.py b/emscripten.py
index f978662c..68fb4aee 100755
--- a/emscripten.py
+++ b/emscripten.py
@@ -413,7 +413,7 @@ var asm = (function(global, env, buffer) {
''' % (asm_setup,) + '\n' + asm_global_vars + '''
var __THREW__ = 0;
var undef = 0;
- var tempInt = 0, tempBigInt = 0, tempBigIntP = 0, tempBigIntS = 0, tempBigIntR = 0.0, tempBigIntI = 0, tempBigIntD = 0, tempValue = 0;
+ var tempInt = 0, tempBigInt = 0, tempBigIntP = 0, tempBigIntS = 0, tempBigIntR = 0.0, tempBigIntI = 0, tempBigIntD = 0, tempValue = 0, tempDouble = 0.0;
''' + ''.join(['''
var tempRet%d = 0;''' % i for i in range(10)]) + '\n' + asm_global_funcs + '''
function stackAlloc(size) {
diff --git a/src/parseTools.js b/src/parseTools.js
index cceba188..b94d9eaa 100644
--- a/src/parseTools.js
+++ b/src/parseTools.js
@@ -1892,6 +1892,11 @@ function makeRounding(value, bits, signed, floatConversion) {
}
}
+function makeIsNaN(value) {
+ if (ASM_JS) return makeInlineCalculation('((VALUE) != (VALUE))', value, 'tempDouble');
+ return 'isNaN(' + value + ')';
+}
+
// fptoui and fptosi are not in these, because we need to be careful about what we do there. We can't
// just sign/unsign the input first.
var UNSIGNED_OP = set('udiv', 'urem', 'uitofp', 'zext', 'lshr');
@@ -2208,8 +2213,8 @@ function processMathop(item) {
case 'ult': case 'olt': return idents[0] + ' < ' + idents[1];
case 'une': case 'one': return idents[0] + ' != ' + idents[1];
case 'ueq': case 'oeq': return idents[0] + ' == ' + idents[1];
- case 'ord': return '!isNaN(' + idents[0] + ') && !isNaN(' + idents[1] + ')';
- case 'uno': return 'isNaN(' + idents[0] + ') || isNaN(' + idents[1] + ')';
+ case 'ord': return '!' + makeIsNaN(idents[0]) + ' & !' + makeIsNaN(idents[1]);
+ case 'uno': return makeIsNaN(idents[0]) + ' | ' + makeIsNaN(idents[1]);
case 'true': return '1';
default: throw 'Unknown fcmp variant: ' + variant;
}