aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAlon Zakai <alonzakai@gmail.com>2013-03-08 10:22:16 -0800
committerAlon Zakai <alonzakai@gmail.com>2013-03-08 10:22:16 -0800
commita3fa0380155176e4d60159ccc5f2a264268863ac (patch)
tree453092e7b4772a76258eb3fa9809e070be08500d
parent82ddb0715d1aa655841223cff314a5377fe10aa5 (diff)
deprecate USE_TYPED_ARRAYS=1 and QUANTUM_SIZE=1
-rw-r--r--src/settings.js4
-rwxr-xr-xtests/runner.py4
2 files changed, 3 insertions, 5 deletions
diff --git a/src/settings.js b/src/settings.js
index 1bfcf92a..440d5094 100644
--- a/src/settings.js
+++ b/src/settings.js
@@ -15,7 +15,7 @@ var QUANTUM_SIZE = 4; // This is the size of an individual field in a structure.
// the normal value of 4 means all fields take 4 memory addresses,
// as per the norm on a 32-bit machine.
//
- // 1 is somewhat faster than 4, but dangerous.
+ // Changing this from the default of 4 is deprecated.
var CORRECT_SIGNS = 1; // Whether we make sure to convert unsigned values to signed values.
// Decreases performance with additional runtime checks. Might not be
@@ -63,7 +63,7 @@ var RELOOPER = 'relooper.js'; // Loads the relooper from this path relative to c
var USE_TYPED_ARRAYS = 2; // Use typed arrays for the heap. See https://github.com/kripken/emscripten/wiki/Code-Generation-Modes/
// 0 means no typed arrays are used.
// 1 has two heaps, IHEAP (int32) and FHEAP (double),
- // and addresses there are a match for normal addresses.
+ // and addresses there are a match for normal addresses. This is deprecated.
// 2 is a single heap, accessible through views as int8, int32, etc. This is
// the recommended mode both for performance and for compatibility.
var USE_FHEAP = 1; // Relevant in USE_TYPED_ARRAYS == 1. If this is disabled, only IHEAP will be used, and FHEAP
diff --git a/tests/runner.py b/tests/runner.py
index 719cf5f4..cdc8684b 100755
--- a/tests/runner.py
+++ b/tests/runner.py
@@ -445,7 +445,7 @@ if 'benchmark' not in str(sys.argv) and 'sanity' not in str(sys.argv) and 'brows
if len(sys.argv) == 2 and 'ALL.' in sys.argv[1]:
ignore, test = sys.argv[1].split('.')
print 'Running all test modes on test "%s"' % test
- sys.argv = [sys.argv[0], 'default.'+test, 'o1.'+test, 'o2.'+test, 'asm2.'+test, 's_0_0.'+test, 's_0_1.'+test, 's_0_1_q1.'+test, 's_1_0.'+test, 's_1_1.'+test, 's_1_1_q1.'+test]
+ sys.argv = [sys.argv[0], 'default.'+test, 'o1.'+test, 'o2.'+test, 'asm2.'+test, 's_0_0.'+test, 's_0_1.'+test, 's_1_0.'+test, 's_1_1.'+test]
class T(RunnerCore): # Short name, to make it more fun to use manually on the commandline
## Does a complete test - builds, runs, checks output, etc.
@@ -8529,8 +8529,6 @@ TT = %s
# Make custom runs with various options
for compiler, quantum, embetter, typed_arrays, llvm_opts in [
- (CLANG, 1, 1, 0, 0),
- (CLANG, 1, 1, 1, 1),
(CLANG, 4, 0, 0, 0),
(CLANG, 4, 0, 0, 1),
(CLANG, 4, 1, 1, 0),