diff options
| author | Alon Zakai <alonzakai@gmail.com> | 2013-11-13 21:46:31 -0800 |
|---|---|---|
| committer | Alon Zakai <alonzakai@gmail.com> | 2013-11-13 21:46:31 -0800 |
| commit | 4eec671ca6d6ebec95e542bd698e879fb642f8c9 (patch) | |
| tree | b8a958e43db9973665f82dfe57d4f9f927add4ab | |
| parent | 03d51f9684f6f7007751a94d0900030df701bae2 (diff) | |
don't show both errors and warnings on undefined symbols
| -rw-r--r-- | src/jsifier.js | 2 | ||||
| -rw-r--r-- | tests/test_other.py | 1 |
2 files changed, 2 insertions, 1 deletions
diff --git a/src/jsifier.js b/src/jsifier.js index fca80a53..22a230ca 100644 --- a/src/jsifier.js +++ b/src/jsifier.js @@ -497,7 +497,7 @@ function JSify(data, functionsOnly, givenFunctions) { } if (!LINKABLE && !LibraryManager.library.hasOwnProperty(shortident) && !LibraryManager.library.hasOwnProperty(shortident + '__inline')) { if (ERROR_ON_UNDEFINED_SYMBOLS) error('unresolved symbol: ' + shortident); - if (VERBOSE || WARN_ON_UNDEFINED_SYMBOLS) warn('unresolved symbol: ' + shortident); + else if (VERBOSE || WARN_ON_UNDEFINED_SYMBOLS) warn('unresolved symbol: ' + shortident); if (ASM_JS) { // emit a stub that will fail during runtime. this allows asm validation to succeed. LibraryManager.library[shortident] = new Function("Module['printErr']('missing function: " + shortident + "'); abort(-1);"); diff --git a/tests/test_other.py b/tests/test_other.py index c1621e63..18404fe7 100644 --- a/tests/test_other.py +++ b/tests/test_other.py @@ -1470,6 +1470,7 @@ f.close() elif action == 'ERROR' and value: self.assertContained('unresolved symbol: something', output[1]) self.assertContained('unresolved symbol: elsey', output[1]) + self.assertNotContained('warning', output[1]) assert not os.path.exists('a.out.js') elif action == 'WARN' and not value: self.assertNotContained('unresolved symbol', output[1]) |