diff options
author | Fraser Adams <fraser.adams@blueyonder.co.uk> | 2013-10-15 18:14:40 +0100 |
---|---|---|
committer | Fraser Adams <fraser.adams@blueyonder.co.uk> | 2013-10-15 18:14:40 +0100 |
commit | 0c7ec24c3f7c50d90d3b6f32c941115fc0610984 (patch) | |
tree | 3441fa3b76a6f6b95427b7da390e5774bd1a8e98 | |
parent | 9bb6dc2d2c32d2a43af1e63e4dee48f4e24540b7 (diff) |
removed comment in src/shell.js and explicitly called run_js with engine=NODE_JS as requested
-rw-r--r-- | src/shell.js | 2 | ||||
-rw-r--r-- | tests/test_other.py | 8 |
2 files changed, 4 insertions, 6 deletions
diff --git a/src/shell.js b/src/shell.js index bb89ab6e..be23b3c1 100644 --- a/src/shell.js +++ b/src/shell.js @@ -68,8 +68,6 @@ if (ENVIRONMENT_IS_NODE) { Module['arguments'] = process['argv'].slice(2); - // Explicitly using associative array form instead of dot notation form prevents the closure compiler - // minifying the exports property, which is important if Module is to remain visible to node.js module['exports'] = Module; } else if (ENVIRONMENT_IS_SHELL) { diff --git a/tests/test_other.py b/tests/test_other.py index 95e0afe4..de46098d 100644 --- a/tests/test_other.py +++ b/tests/test_other.py @@ -1931,8 +1931,8 @@ done. # Check that main.js (which requires test.js) completes successfully when run in node.js # in order to check that the exports are indeed functioning correctly. - for engine in JS_ENGINES: - if engine == NODE_JS: self.assertContained('bufferTest finished', run_js(path_from_root('tests', 'Module-exports', 'main.js'))) + if NODE_JS in JS_ENGINES: + self.assertContained('bufferTest finished', run_js(path_from_root('tests', 'Module-exports', 'main.js'), engine=NODE_JS)) # Delete test.js again and check it's gone. try_delete(path_from_root('tests', 'Module-exports', 'test.js')) @@ -1951,8 +1951,8 @@ done. # Check that main.js (which requires test.js) completes successfully when run in node.js # in order to check that the exports are indeed functioning correctly. - for engine in JS_ENGINES: - if engine == NODE_JS: self.assertContained('bufferTest finished', run_js(path_from_root('tests', 'Module-exports', 'main.js'))) + if NODE_JS in JS_ENGINES: + self.assertContained('bufferTest finished', run_js(path_from_root('tests', 'Module-exports', 'main.js'), engine=NODE_JS)) # Tidy up files that might have been created by this test. try_delete(path_from_root('tests', 'Module-exports', 'test.js')) |