From 1c0cea6c1fc807794f0d785392e05b19d0c70210 Mon Sep 17 00:00:00 2001 From: Mark Seaborn Date: Mon, 9 Sep 2013 10:06:19 -0700 Subject: PNaCl bitcode: Change FORWARDTYPEREF to never use pointer types Before, FORWARDTYPEREFs used i8* type rather than i32 if they referenced an "alloca" instruction. Clean this up so that FORWARDTYPEREFs use i32 instead in this case. Note that this means that a forward-referenced "alloca" can be used via an ptrtoint+inttoptr, rather than a bitcast, but that's no problem. This is a step towards removing TYPE_CODE_POINTER from the types table, to simplify the PNaCl bitcode format. Rename NormalizeParamType() to NormalizeScalarType() to reflect that it's used in more cases; make it public. BUG=https://code.google.com/p/nativeclient/issues/detail?id=3671 TEST=test/NaCl/Bitcode/*.ll Review URL: https://codereview.chromium.org/23719016 --- lib/Bitcode/NaCl/Writer/NaClBitcodeWriter.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'lib/Bitcode/NaCl/Writer/NaClBitcodeWriter.cpp') diff --git a/lib/Bitcode/NaCl/Writer/NaClBitcodeWriter.cpp b/lib/Bitcode/NaCl/Writer/NaClBitcodeWriter.cpp index 6432740ba2..923d0b2c1e 100644 --- a/lib/Bitcode/NaCl/Writer/NaClBitcodeWriter.cpp +++ b/lib/Bitcode/NaCl/Writer/NaClBitcodeWriter.cpp @@ -550,7 +550,7 @@ static void EmitFnForwardTypeRef(const Value *V, VE.InsertFnForwardTypeRef(ValID)) { SmallVector Vals; Vals.push_back(ValID); - Vals.push_back(VE.getTypeID(V->getType())); + Vals.push_back(VE.getTypeID(VE.NormalizeScalarType(V->getType()))); Stream.EmitRecord(naclbitc::FUNC_CODE_INST_FORWARDTYPEREF, Vals, FUNCTION_INST_FORWARDTYPEREF_ABBREV); } -- cgit v1.2.3-18-g5258