diff options
Diffstat (limited to 'lib/CodeGen/BranchFolding.cpp')
-rw-r--r-- | lib/CodeGen/BranchFolding.cpp | 42 |
1 files changed, 23 insertions, 19 deletions
diff --git a/lib/CodeGen/BranchFolding.cpp b/lib/CodeGen/BranchFolding.cpp index 3887e6d44e..7ac8bda7a3 100644 --- a/lib/CodeGen/BranchFolding.cpp +++ b/lib/CodeGen/BranchFolding.cpp @@ -1205,11 +1205,11 @@ ReoptimizeBlock: } } - // If the prior block doesn't fall through into this block, and if this - // block doesn't fall through into some other block, see if we can find a - // place to move this block where a fall-through will happen. - if (!PrevBB.canFallThrough()) { - + // If the prior block doesn't fall through into this block and if this block + // doesn't fall through into some other block and it's not branching only to a + // landing pad, then see if we can find a place to move this block where a + // fall-through will happen. + if (!PrevBB.canFallThrough() && !MBB->BranchesToLandingPad(MBB)) { // Now we know that there was no fall-through into this block, check to // see if it has a fall-through into its successor. bool CurFallsThru = MBB->canFallThrough(); @@ -1221,28 +1221,32 @@ ReoptimizeBlock: E = MBB->pred_end(); PI != E; ++PI) { // Analyze the branch at the end of the pred. MachineBasicBlock *PredBB = *PI; - MachineFunction::iterator PredFallthrough = PredBB; ++PredFallthrough; + MachineFunction::iterator PredNextBB = PredBB; ++PredNextBB; MachineBasicBlock *PredTBB, *PredFBB; SmallVector<MachineOperand, 4> PredCond; - if (PredBB != MBB && !PredBB->canFallThrough() && - !TII->AnalyzeBranch(*PredBB, PredTBB, PredFBB, PredCond, true) + if (PredBB != MBB && !PredBB->canFallThrough() + && !TII->AnalyzeBranch(*PredBB, PredTBB, PredFBB, PredCond, true) && (!CurFallsThru || !CurTBB || !CurFBB) && (!CurFallsThru || MBB->getNumber() >= PredBB->getNumber())) { - // If the current block doesn't fall through, just move it. - // If the current block can fall through and does not end with a - // conditional branch, we need to append an unconditional jump to - // the (current) next block. To avoid a possible compile-time - // infinite loop, move blocks only backward in this case. - // Also, if there are already 2 branches here, we cannot add a third; - // this means we have the case - // Bcc next - // B elsewhere - // next: + // If the current block doesn't fall through, just move it. If the + // current block can fall through and does not end with a conditional + // branch, we need to append an unconditional jump to the (current) + // next block. To avoid a possible compile-time infinite loop, move + // blocks only backward in this case. + // + // Also, if there are already 2 branches here, we cannot add a third. + // I.e. we have the case: + // + // Bcc next + // B elsewhere + // next: if (CurFallsThru) { - MachineBasicBlock *NextBB = llvm::next(MachineFunction::iterator(MBB)); + MachineBasicBlock *NextBB = + llvm::next(MachineFunction::iterator(MBB)); CurCond.clear(); TII->InsertBranch(*MBB, NextBB, 0, CurCond); } + MBB->moveAfter(PredBB); MadeChange = true; goto ReoptimizeBlock; |