diff options
| author | Mark Seaborn <mseaborn@chromium.org> | 2013-05-31 09:56:47 -0700 |
|---|---|---|
| committer | Mark Seaborn <mseaborn@chromium.org> | 2013-05-31 09:56:47 -0700 |
| commit | b74fb76de6dba430089e94fd5e8d0fa856cda3cc (patch) | |
| tree | f2f11f6e40421cc3803a52e7f831f3c78d444cf3 /test | |
| parent | 99c2f236a1a09b6c550e91b71dabbbb0e634ea37 (diff) | |
PNaCl: Remove and disallow llvm.invariant.start/end intrinsics
These markers work in a similar way to llvm.lifetime.start/end, so we
should remove them for similar reasons: it's not very well defined how
one marker cancels out the effects of the other.
Arguably, invariant.start/end are less useful than lifetime.start/end.
They are ignored by the backend. They are generated in fewer places:
invariant.start is generated by Clang (at -O1 or higher) when a const
global is initialised with a non-POD initialiser. invariant.end is
apparently not generated at all.
Do the stripping in ReplacePtrsWithInts for consistency with the
existing lifetime.start/end stripping.
BUG=https://code.google.com/p/nativeclient/issues/detail?id=3443
TEST=PNaCl toolchain trybots
Review URL: https://codereview.chromium.org/15995004
Diffstat (limited to 'test')
| -rw-r--r-- | test/Transforms/NaCl/replace-ptrs-with-ints.ll | 12 |
1 files changed, 12 insertions, 0 deletions
diff --git a/test/Transforms/NaCl/replace-ptrs-with-ints.ll b/test/Transforms/NaCl/replace-ptrs-with-ints.ll index bab6101848..d7e85f6da6 100644 --- a/test/Transforms/NaCl/replace-ptrs-with-ints.ll +++ b/test/Transforms/NaCl/replace-ptrs-with-ints.ll @@ -447,6 +447,8 @@ define void @debug_value(i32 %val, i8* %ptr) { declare void @llvm.lifetime.start(i64 %size, i8* %ptr) +declare void @llvm.invariant.start(i64 %size, i8* %ptr) +declare void @llvm.invariant.end(i64 %size, i8* %ptr) ; GVN can introduce the following horrible corner case of a lifetime ; marker referencing a PHI node. But we convert the phi to i32 type, @@ -486,6 +488,16 @@ define void @alloca_lifetime_via_bitcast() { ; CHECK-NEXT: %buf = alloca [4 x i8] ; CHECK-NEXT: ret void +define void @strip_invariant_markers() { + %buf = alloca i8 + call void @llvm.invariant.start(i64 1, i8* %buf) + call void @llvm.invariant.end(i64 1, i8* %buf) + ret void +} +; CHECK: define void @strip_invariant_markers() { +; CHECK-NEXT: %buf = alloca [1 x i8] +; CHECK-NEXT: ret void + ; "nocapture" and "noalias" only apply to pointers, so must be stripped. define void @nocapture_attr(i8* nocapture noalias %ptr) { |