diff options
author | Daniel Dunbar <daniel@zuster.org> | 2013-01-16 21:38:56 +0000 |
---|---|---|
committer | Daniel Dunbar <daniel@zuster.org> | 2013-01-16 21:38:56 +0000 |
commit | 5db391c67d0922f4ab2ba57c07def19759c801a4 (patch) | |
tree | c6ccfc058d52546a49b612627a9e48f2aac332d4 /lib | |
parent | d3c965d6251e6d939f7797f8704d4e3a82f7e274 (diff) |
[IR] Add 'Append' and 'AppendUnique' module flag behaviors.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@172659 91177308-0d34-0410-b5e6-96231b3b80d8
Diffstat (limited to 'lib')
-rw-r--r-- | lib/IR/Verifier.cpp | 46 | ||||
-rw-r--r-- | lib/Linker/LinkModules.cpp | 28 |
2 files changed, 61 insertions, 13 deletions
diff --git a/lib/IR/Verifier.cpp b/lib/IR/Verifier.cpp index 2488a7de16..49821f24f2 100644 --- a/lib/IR/Verifier.cpp +++ b/lib/IR/Verifier.cpp @@ -571,24 +571,25 @@ void Verifier::visitModuleFlag(MDNode *Op, DenseMap<MDString*, MDNode*>&SeenIDs, "invalid behavior operand in module flag (expected constant integer)", Op->getOperand(0)); unsigned BehaviorValue = Behavior->getZExtValue(); - Assert1((Module::Error <= BehaviorValue && - BehaviorValue <= Module::Override), - "invalid behavior operand in module flag (unexpected constant)", - Op->getOperand(0)); Assert1(ID, "invalid ID operand in module flag (expected metadata string)", Op->getOperand(1)); - // Unless this is a "requires" flag, check the ID is unique. - if (BehaviorValue != Module::Require) { - bool Inserted = SeenIDs.insert(std::make_pair(ID, Op)).second; - Assert1(Inserted, - "module flag identifiers must be unique (or of 'require' type)", - ID); - } + // Sanity check the values for behaviors with additional requirements. + switch (BehaviorValue) { + default: + Assert1(false, + "invalid behavior operand in module flag (unexpected constant)", + Op->getOperand(0)); + break; - // If this is a "requires" flag, sanity check the value. - if (BehaviorValue == Module::Require) { + case Module::Error: + case Module::Warning: + case Module::Override: + // These behavior types accept any value. + break; + + case Module::Require: { // The value should itself be an MDNode with two operands, a flag ID (an // MDString), and a value. MDNode *Value = dyn_cast<MDNode>(Op->getOperand(2)); @@ -603,6 +604,25 @@ void Verifier::visitModuleFlag(MDNode *Op, DenseMap<MDString*, MDNode*>&SeenIDs, // Append it to the list of requirements, to check once all module flags are // scanned. Requirements.push_back(Value); + break; + } + + case Module::Append: + case Module::AppendUnique: { + // These behavior types require the operand be an MDNode. + Assert1(isa<MDNode>(Op->getOperand(2)), + "invalid value for 'append'-type module flag " + "(expected a metadata node)", Op->getOperand(2)); + break; + } + } + + // Unless this is a "requires" flag, check the ID is unique. + if (BehaviorValue != Module::Require) { + bool Inserted = SeenIDs.insert(std::make_pair(ID, Op)).second; + Assert1(Inserted, + "module flag identifiers must be unique (or of 'require' type)", + ID); } } diff --git a/lib/Linker/LinkModules.cpp b/lib/Linker/LinkModules.cpp index 1b4ef324d7..3b8928a324 100644 --- a/lib/Linker/LinkModules.cpp +++ b/lib/Linker/LinkModules.cpp @@ -1086,6 +1086,34 @@ bool ModuleLinker::linkModuleFlagsMetadata() { } continue; } + case Module::Append: { + MDNode *DstValue = cast<MDNode>(DstOp->getOperand(2)); + MDNode *SrcValue = cast<MDNode>(SrcOp->getOperand(2)); + unsigned NumOps = DstValue->getNumOperands() + SrcValue->getNumOperands(); + Value **VP, **Values = VP = new Value*[NumOps]; + for (unsigned i = 0, e = DstValue->getNumOperands(); i != e; ++i, ++VP) + *VP = DstValue->getOperand(i); + for (unsigned i = 0, e = SrcValue->getNumOperands(); i != e; ++i, ++VP) + *VP = SrcValue->getOperand(i); + DstOp->replaceOperandWith(2, MDNode::get(DstM->getContext(), + ArrayRef<Value*>(Values, + NumOps))); + delete[] Values; + break; + } + case Module::AppendUnique: { + SmallSetVector<Value*, 16> Elts; + MDNode *DstValue = cast<MDNode>(DstOp->getOperand(2)); + MDNode *SrcValue = cast<MDNode>(SrcOp->getOperand(2)); + for (unsigned i = 0, e = DstValue->getNumOperands(); i != e; ++i) + Elts.insert(DstValue->getOperand(i)); + for (unsigned i = 0, e = SrcValue->getNumOperands(); i != e; ++i) + Elts.insert(SrcValue->getOperand(i)); + DstOp->replaceOperandWith(2, MDNode::get(DstM->getContext(), + ArrayRef<Value*>(Elts.begin(), + Elts.end()))); + break; + } } } |