diff options
author | Dale Johannesen <dalej@apple.com> | 2010-06-24 20:14:51 +0000 |
---|---|---|
committer | Dale Johannesen <dalej@apple.com> | 2010-06-24 20:14:51 +0000 |
commit | e5ff9ef195722cbbf4b6ed7d34412f7277d05eda (patch) | |
tree | 7e9f5b5b8794b8939c501aaa5bfd33697616ebd4 /lib | |
parent | dd6f86a28f1ae77ec2a35598f6a7a934dd5d802f (diff) |
Disallow matching "i" constraint to symbol addresses when
address requires a register or secondary load to compute
(most PIC modes). This improves "g" constraint handling. 8015842.
The test from 2007 is attempting to test the fix for PR1761,
but since -relocation-model=static doesn't work on Darwin
x86-64, it was not testing what it was supposed to be testing
and was passing erroneously. Fixed to use Linux x86-64.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@106779 91177308-0d34-0410-b5e6-96231b3b80d8
Diffstat (limited to 'lib')
-rw-r--r-- | lib/Target/X86/X86ISelLowering.cpp | 7 |
1 files changed, 7 insertions, 0 deletions
diff --git a/lib/Target/X86/X86ISelLowering.cpp b/lib/Target/X86/X86ISelLowering.cpp index da10a6f2ca..bed9d1d1a8 100644 --- a/lib/Target/X86/X86ISelLowering.cpp +++ b/lib/Target/X86/X86ISelLowering.cpp @@ -10222,6 +10222,13 @@ void X86TargetLowering::LowerAsmOperandForConstraint(SDValue Op, break; } + // In any sort of PIC mode addresses need to be computed at runtime by + // adding in a register or some sort of table lookup. These can't + // be used as immediates. + if (Subtarget->isPICStyleGOT() || Subtarget->isPICStyleStubPIC() || + Subtarget->isPICStyleRIPRel()) + return; + // If we are in non-pic codegen mode, we allow the address of a global (with // an optional displacement) to be used with 'i'. GlobalAddressSDNode *GA = 0; |