PNaCl pexe reader: Remove now-unused Type argument from getValue()/popValue()

Before this change, NaClBitcodeReader had some icky use of C++
function overloading and reference types.  Whether getValue() modified
its Slot argument depended on whether it was passed a Type argument,
which wasn't very readable:

  // Modifies Slot.
  bool getValue(SmallVector<uint64_t, 64> &Record, unsigned &Slot,
                unsigned InstNum, Value *&ResVal);
  // Does not modify Slot.
  bool getValue(SmallVector<uint64_t, 64> &Record, unsigned Slot,
                unsigned InstNum, Type *Ty, Value *&ResVal);
  // Does not modify Slot.
  Value *getValue(SmallVector<uint64_t, 64> &Record, unsigned Slot,
                  unsigned InstNum, Type *Ty);

So, do these cleanups:

 * Convert non-const reference arguments to pointers.  (Also add
   "const" to the Record argument.)

 * Remove the unused Type argument from getValue()/popValue().

 * Remove the getValue() case that was identical to popValue().  Call
   popValue() instead.  Now popValue() modifies *Slot and getValue()
   does not.

 * Remove an unused getValue() case.

BUG=https://code.google.com/p/nativeclient/issues/detail?id=3507
TEST=PNaCl toolchain trybots

Review URL: https://codereview.chromium.org/17938002

0 files changed, 0 insertions, 0 deletions