diff options
| author | Karl Schimpf <kschimpf@google.com> | 2013-07-03 11:02:54 -0700 |
|---|---|---|
| committer | Karl Schimpf <kschimpf@google.com> | 2013-07-03 11:02:54 -0700 |
| commit | c68c47198c0e0a610e49eaf072429b9214fca04f (patch) | |
| tree | cfa16f856e7debe229f1d18da1e874057743d36d /lib/Bitcode/NaCl/Writer/NaClValueEnumerator.cpp | |
| parent | c5f0da9f2a5ffb5d9e8803839655f2f3d6972d83 (diff) | |
Don't generate Type ID's for global variable fields.
Also removed local MaxGlobalType in WriteModuleInfo because it calls VE.getTypeID(GV->getTYpe(), which is no longer defined for globals.
Also noted that MaxAlignment in WriteModuleInfo was no longer used and removed it.
BUG= https://code.google.com/p/nativeclient/issues/detail?id=3541
R=mseaborn@chromium.org
Review URL: https://codereview.chromium.org/18185005
Diffstat (limited to 'lib/Bitcode/NaCl/Writer/NaClValueEnumerator.cpp')
| -rw-r--r-- | lib/Bitcode/NaCl/Writer/NaClValueEnumerator.cpp | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/lib/Bitcode/NaCl/Writer/NaClValueEnumerator.cpp b/lib/Bitcode/NaCl/Writer/NaClValueEnumerator.cpp index 393c5bc934..5e2484a3f3 100644 --- a/lib/Bitcode/NaCl/Writer/NaClValueEnumerator.cpp +++ b/lib/Bitcode/NaCl/Writer/NaClValueEnumerator.cpp @@ -243,8 +243,10 @@ void NaClValueEnumerator::EnumerateValue(const Value *V) { return; } - // Enumerate the type of this value. - EnumerateType(V->getType()); + // Enumerate the type of this value. Skip global values since no + // types are dumped for global variables. + if (!isa<GlobalVariable>(V)) + EnumerateType(V->getType()); if (const Constant *C = dyn_cast<Constant>(V)) { if (isa<GlobalValue>(C)) { |