diff options
| author | Mark Seaborn <mseaborn@chromium.org> | 2013-05-31 09:56:47 -0700 |
|---|---|---|
| committer | Mark Seaborn <mseaborn@chromium.org> | 2013-05-31 09:56:47 -0700 |
| commit | b74fb76de6dba430089e94fd5e8d0fa856cda3cc (patch) | |
| tree | f2f11f6e40421cc3803a52e7f831f3c78d444cf3 /lib/Analysis | |
| parent | 99c2f236a1a09b6c550e91b71dabbbb0e634ea37 (diff) | |
PNaCl: Remove and disallow llvm.invariant.start/end intrinsics
These markers work in a similar way to llvm.lifetime.start/end, so we
should remove them for similar reasons: it's not very well defined how
one marker cancels out the effects of the other.
Arguably, invariant.start/end are less useful than lifetime.start/end.
They are ignored by the backend. They are generated in fewer places:
invariant.start is generated by Clang (at -O1 or higher) when a const
global is initialised with a non-POD initialiser. invariant.end is
apparently not generated at all.
Do the stripping in ReplacePtrsWithInts for consistency with the
existing lifetime.start/end stripping.
BUG=https://code.google.com/p/nativeclient/issues/detail?id=3443
TEST=PNaCl toolchain trybots
Review URL: https://codereview.chromium.org/15995004
Diffstat (limited to 'lib/Analysis')
| -rw-r--r-- | lib/Analysis/NaCl/PNaClABIVerifyModule.cpp | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/lib/Analysis/NaCl/PNaClABIVerifyModule.cpp b/lib/Analysis/NaCl/PNaClABIVerifyModule.cpp index 9b2def5ac4..d977175b67 100644 --- a/lib/Analysis/NaCl/PNaClABIVerifyModule.cpp +++ b/lib/Analysis/NaCl/PNaClABIVerifyModule.cpp @@ -161,8 +161,6 @@ bool PNaClABIVerifyModule::isWhitelistedIntrinsic(const Function *F, default: return false; // (1) Always allowed. case Intrinsic::bswap: return isWhitelistedBswap(F); - case Intrinsic::invariant_end: - case Intrinsic::invariant_start: case Intrinsic::memcpy: case Intrinsic::memmove: case Intrinsic::memset: @@ -215,6 +213,8 @@ bool PNaClABIVerifyModule::isWhitelistedIntrinsic(const Function *F, // See https://code.google.com/p/nativeclient/issues/detail?id=3443 case Intrinsic::lifetime_end: case Intrinsic::lifetime_start: + case Intrinsic::invariant_end: + case Intrinsic::invariant_start: return false; // (3) Dev intrinsics. |