diff options
| author | Jan Voung <jvoung@chromium.org> | 2013-06-19 16:12:25 -0700 |
|---|---|---|
| committer | Jan Voung <jvoung@chromium.org> | 2013-06-19 16:12:25 -0700 |
| commit | 73af8c9c57122e5ae61f80d916653db0dbb1e91f (patch) | |
| tree | 49fdcd5d299096f2cf86f9eb8360394ef5d14054 /lib/Analysis | |
| parent | bce9cade729651fdddd9852d0467e0cd7476a54f (diff) | |
Rewrite llvm.flt.rounds to "1" for now, and disallow llvm.flt.rounds.
Until there is an intrinsic to *set* the rounding mode,
this intrinsic to *get* the rounding mode isn't so useful.
Separately we will add a test that for each platform, the
initial rounding mode is "1" (round to nearest). That is
the case right now for x86, ARM, and MIPS.
(see https://codereview.chromium.org/16785003/)
BUG=https://code.google.com/p/nativeclient/issues/detail?id=3491
R=mseaborn@chromium.org
Review URL: https://codereview.chromium.org/17229007
Diffstat (limited to 'lib/Analysis')
| -rw-r--r-- | lib/Analysis/NaCl/PNaClABIVerifyModule.cpp | 7 |
1 files changed, 4 insertions, 3 deletions
diff --git a/lib/Analysis/NaCl/PNaClABIVerifyModule.cpp b/lib/Analysis/NaCl/PNaClABIVerifyModule.cpp index 3a422288d8..288d5da2ad 100644 --- a/lib/Analysis/NaCl/PNaClABIVerifyModule.cpp +++ b/lib/Analysis/NaCl/PNaClABIVerifyModule.cpp @@ -249,6 +249,10 @@ bool PNaClABIVerifyModule::isWhitelistedIntrinsic(const Function *F, // We run -lower-expect to convert Intrinsic::expect into branch weights // and consume in the middle-end. The backend just ignores llvm.expect. case Intrinsic::expect: + // For FLT_ROUNDS macro from float.h. It works for ARM and X86 + // (but not MIPS). Also, wait until we add a set_flt_rounds intrinsic + // before we bless this. + case Intrinsic::flt_rounds: return false; // (3) Dev intrinsics. @@ -258,9 +262,6 @@ bool PNaClABIVerifyModule::isWhitelistedIntrinsic(const Function *F, case Intrinsic::ctlz: // Support via compiler_rt if arch doesn't have it? case Intrinsic::ctpop: // Support via compiler_rt if arch doesn't have it? case Intrinsic::cttz: // Support via compiler_rt if arch doesn't have it? - case Intrinsic::flt_rounds: // For FLT_ROUNDS macro from float.h. - // We do not have fesetround() in newlib, can we return a - // consistent rounding mode though? case Intrinsic::nacl_target_arch: // Used by translator self-build. case Intrinsic::pow: // Rounding is supposed to be the same as libm. case Intrinsic::powi: // Rounding not defined: support with fast-math? |