diff options
| author | Derek Schuff <dschuff@chromium.org> | 2013-05-29 10:27:19 -0700 |
|---|---|---|
| committer | Derek Schuff <dschuff@chromium.org> | 2013-05-29 10:27:19 -0700 |
| commit | dc58e24a36836fc19c534bdcbef5152717a3c3fc (patch) | |
| tree | 343a9c7047b58bcffb5466acb7dc3f52a481f547 /lib/Analysis | |
| parent | 8d01804c97533ed9006a65c11cade3c6b23d1c75 (diff) | |
Enable integer promotion pass and enable ABI check for integer types.
R=mseaborn@chromium.org
BUG= https://code.google.com/p/nativeclient/issues/detail?id=3360
Review URL: https://codereview.chromium.org/15950006
Diffstat (limited to 'lib/Analysis')
| -rw-r--r-- | lib/Analysis/NaCl/PNaClABITypeChecker.cpp | 14 |
1 files changed, 4 insertions, 10 deletions
diff --git a/lib/Analysis/NaCl/PNaClABITypeChecker.cpp b/lib/Analysis/NaCl/PNaClABITypeChecker.cpp index 8501a4f9e2..5157747f2b 100644 --- a/lib/Analysis/NaCl/PNaClABITypeChecker.cpp +++ b/lib/Analysis/NaCl/PNaClABITypeChecker.cpp @@ -24,7 +24,7 @@ bool PNaClABITypeChecker::isValidType(const Type *Ty) { if (VisitedTypes.count(Ty)) return VisitedTypes[Ty]; - // unsigned Width; + unsigned Width; bool Valid = false; switch (Ty->getTypeID()) { // Allowed primitive types @@ -48,15 +48,9 @@ bool PNaClABITypeChecker::isValidType(const Type *Ty) { Valid = false; break; case Type::IntegerTyID: - // The check for integer sizes below currently does not pass on - // all NaCl tests because some LLVM passes introduce unusual - // integer sizes. - // TODO(mseaborn): Re-enable the check when it passes. - // See https://code.google.com/p/nativeclient/issues/detail?id=3360 - Valid = true; - // Width = cast<const IntegerType>(Ty)->getBitWidth(); - // Valid = (Width == 1 || Width == 8 || Width == 16 || - // Width == 32 || Width == 64); + Width = cast<const IntegerType>(Ty)->getBitWidth(); + Valid = (Width == 1 || Width == 8 || Width == 16 || + Width == 32 || Width == 64); break; case Type::FunctionTyID: case Type::StructTyID: |