aboutsummaryrefslogtreecommitdiff
path: root/lib/Analysis/BasicAliasAnalysis.cpp
diff options
context:
space:
mode:
authorChris Lattner <sabre@nondot.org>2009-11-23 17:07:35 +0000
committerChris Lattner <sabre@nondot.org>2009-11-23 17:07:35 +0000
commitb27db37ed05a846bd2e0fcdaf592e5bb1a573f8b (patch)
tree91e389f410a13731b4481fe156acd9a446fa3ba7 /lib/Analysis/BasicAliasAnalysis.cpp
parent403ac2ece33046c58b66fffa105184f44fa4527e (diff)
fix comment, thanks all :)
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@89666 91177308-0d34-0410-b5e6-96231b3b80d8
Diffstat (limited to 'lib/Analysis/BasicAliasAnalysis.cpp')
-rw-r--r--lib/Analysis/BasicAliasAnalysis.cpp4
1 files changed, 3 insertions, 1 deletions
diff --git a/lib/Analysis/BasicAliasAnalysis.cpp b/lib/Analysis/BasicAliasAnalysis.cpp
index 32ca9111c2..ff65e33ad5 100644
--- a/lib/Analysis/BasicAliasAnalysis.cpp
+++ b/lib/Analysis/BasicAliasAnalysis.cpp
@@ -263,7 +263,9 @@ ImmutablePass *llvm::createBasicAliasAnalysisPass() {
bool BasicAliasAnalysis::pointsToConstantMemory(const Value *P) {
if (const GlobalVariable *GV =
dyn_cast<GlobalVariable>(P->getUnderlyingObject()))
- // FIXME: shouldn't this require GV to be "ODR"?
+ // Note: this doesn't require GV to be "ODR" because it isn't legal for a
+ // global to be marked constant in some modules and non-constant in others.
+ // GV may even be a declaration, not a definition.
return GV->isConstant();
return false;
}