aboutsummaryrefslogtreecommitdiff
path: root/include
diff options
context:
space:
mode:
authorMark Seaborn <mseaborn@chromium.org>2013-09-05 08:46:41 -0700
committerMark Seaborn <mseaborn@chromium.org>2013-09-05 08:46:41 -0700
commit1180f259c88b1eb1000d0aaf5753b3da9f8e4e51 (patch)
tree93e5a4aa9aa5c5cedf8fe2c1137bef15e0ef081a /include
parentd8f9bfbc093e7e0c1fab719bc014ba7c6f94ad6d (diff)
PNaCl bitcode: Don't output the LABEL type in the type table
The type ID for the "label" type is never referenced. The "label" type was only being added to the type table because EnumerateType() treats BasicBlock and Value operands the same. However, the rest of the reader and writer treat BasicBlock operands specially and not like other Values. Change some tests to use wildcards for some type IDs. This is so that I don't have to update all the type ID numbers now that the generated type tables have changed. BUG=https://code.google.com/p/nativeclient/issues/detail?id=3590 TEST=run small_tests with v2 bitcode format enabled Review URL: https://codereview.chromium.org/23530031
Diffstat (limited to 'include')
-rw-r--r--include/llvm/Bitcode/NaCl/NaClLLVMBitCodes.h2
1 files changed, 2 insertions, 0 deletions
diff --git a/include/llvm/Bitcode/NaCl/NaClLLVMBitCodes.h b/include/llvm/Bitcode/NaCl/NaClLLVMBitCodes.h
index 32e3920b7d..384b03661e 100644
--- a/include/llvm/Bitcode/NaCl/NaClLLVMBitCodes.h
+++ b/include/llvm/Bitcode/NaCl/NaClLLVMBitCodes.h
@@ -82,6 +82,8 @@ namespace naclbitc {
TYPE_CODE_VOID = 2, // VOID
TYPE_CODE_FLOAT = 3, // FLOAT
TYPE_CODE_DOUBLE = 4, // DOUBLE
+ // TODO(mseaborn): Remove LABEL when we drop support for v1 of the
+ // PNaCl bitcode format. The writer no longer generates it.
TYPE_CODE_LABEL = 5, // LABEL
TYPE_CODE_OPAQUE = 6, // Not used in PNaCl.
TYPE_CODE_INTEGER = 7, // INTEGER: [width]