diff options
| author | Dale Johannesen <dalej@apple.com> | 2009-04-27 21:03:15 +0000 |
|---|---|---|
| committer | Dale Johannesen <dalej@apple.com> | 2009-04-27 21:03:15 +0000 |
| commit | 617d108a639b29015da2dbf0e54f61bd39c3c33c (patch) | |
| tree | 621e829cbbf7509d9e627df3dea446d2a5254d12 | |
| parent | c45288e06bfe7d0b0e74eff350d280fa6c944373 (diff) | |
Fix PR 4086, a bug in FP IV elimination.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@70247 91177308-0d34-0410-b5e6-96231b3b80d8
| -rw-r--r-- | lib/Transforms/Scalar/IndVarSimplify.cpp | 6 | ||||
| -rw-r--r-- | test/Transforms/IndVarSimplify/2009-04-27-Floating.ll | 18 |
2 files changed, 22 insertions, 2 deletions
diff --git a/lib/Transforms/Scalar/IndVarSimplify.cpp b/lib/Transforms/Scalar/IndVarSimplify.cpp index cc3919da84..141b1181bf 100644 --- a/lib/Transforms/Scalar/IndVarSimplify.cpp +++ b/lib/Transforms/Scalar/IndVarSimplify.cpp @@ -1037,9 +1037,11 @@ void IndVarSimplify::HandleFloatingPointIV(Loop *L, PHINode *PH, Incr->getName()+".int", Incr); NewPHI->addIncoming(NewAdd, PH->getIncomingBlock(BackEdge)); + // The back edge is edge 1 of newPHI, whatever it may have been in the + // original PHI. ConstantInt *NewEV = ConstantInt::get(Type::Int32Ty, intEV); - Value *LHS = (EVIndex == 1 ? NewPHI->getIncomingValue(BackEdge) : NewEV); - Value *RHS = (EVIndex == 1 ? NewEV : NewPHI->getIncomingValue(BackEdge)); + Value *LHS = (EVIndex == 1 ? NewPHI->getIncomingValue(1) : NewEV); + Value *RHS = (EVIndex == 1 ? NewEV : NewPHI->getIncomingValue(1)); ICmpInst *NewEC = new ICmpInst(NewPred, LHS, RHS, EC->getNameStart(), EC->getParent()->getTerminator()); diff --git a/test/Transforms/IndVarSimplify/2009-04-27-Floating.ll b/test/Transforms/IndVarSimplify/2009-04-27-Floating.ll new file mode 100644 index 0000000000..700f294eb8 --- /dev/null +++ b/test/Transforms/IndVarSimplify/2009-04-27-Floating.ll @@ -0,0 +1,18 @@ +; RUN: llvm-as < %s | opt -indvars | llvm-dis | grep icmp | grep next +; PR4086 +declare void @foo() + +define void @test() { +entry: + br label %loop_body + +loop_body: + %i = phi float [ %nexti, %loop_body ], [ 0.0, %entry ] + tail call void @foo() + %nexti = add float %i, 1.0 + %less = fcmp olt float %nexti, 2.0 + br i1 %less, label %loop_body, label %done + +done: + ret void +} |