emscripten-fastcomp/test/CodeGen/X86/StackColoring.ll, branch 1.13.2 LLVM with the emscripten fastcomp javascript backend https://git.amat.us/emscripten-fastcomp/atom/test/CodeGen/X86/StackColoring.ll?h=1.13.2 2013-05-17T18:24:54Z Cherry-pick r181922: Fix miscompile due to StackColoring incorrectly merging stack slots (PR15707) 2013-05-17T18:24:54Z Mark Seaborn mseaborn@chromium.org 2013-05-17T18:24:54Z urn:sha1:4284726d05e5a8397e66e259c3bba323f0966267 IR optimisation passes can result in a basic block that contains: llvm.lifetime.start(%buf) ... llvm.lifetime.end(%buf) ... llvm.lifetime.start(%buf) Before this change, calculateLiveIntervals() was ignoring the second lifetime.start() and was regarding %buf as being dead from the lifetime.end() through to the end of the basic block. This can cause StackColoring to incorrectly merge %buf with another stack slot. Fix by removing the incorrect Starts[pos].isValid() and Finishes[pos].isValid() checks. Just doing: Starts[pos] = Indexes->getMBBStartIdx(MBB); Finishes[pos] = Indexes->getMBBEndIdx(MBB); unconditionally would be enough to fix the bug, but it causes some test failures due to stack slots not being merged when they were before. So, in order to keep the existing tests passing, treat LiveIn and LiveOut separately rather than approximating the live ranges by merging LiveIn and LiveOut. This fixes PR15707. Patch by Mark Seaborn. BUG=https://code.google.com/p/nativeclient/issues/detail?id=3374 Review URL: https://codereview.chromium.org/15302009 Stack Coloring: We have code that checks that all of the uses of allocas 2012-09-13T12:38:37Z Nadav Rotem nrotem@apple.com 2012-09-13T12:38:37Z urn:sha1:0cd19b93017fcaba737b15ea4da39c460feb5670 are within the lifetime zone. Sometime legitimate usages of allocas are hoisted outside of the lifetime zone. For example, GEPS may calculate the address of a member of an allocated struct. This commit makes sure that we only check (abort regions or assert) for instructions that read and write memory using stack frames directly. Notice that by allowing legitimate usages outside the lifetime zone we also stop checking for instructions which use derivatives of allocas. We will catch less bugs in user code and in the compiler itself. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@163791 91177308-0d34-0410-b5e6-96231b3b80d8 Stack coloring: remove lifetime intervals which contain escaped allocas. 2012-09-12T04:57:37Z Nadav Rotem nrotem@apple.com 2012-09-12T04:57:37Z urn:sha1:0a16da445740ca6fcd7a7ca571c1917e77315904 The input program may contain intructions which are not inside lifetime markers. This can happen due to a bug in the compiler or due to a bug in user code (for example, returning a reference to a local variable). This commit adds checks that all of the instructions in the function and invalidates lifetime ranges which do not contain all of the instructions. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@163678 91177308-0d34-0410-b5e6-96231b3b80d8 Stack Coloring: Handle the case where END markers come before BEGIN markers properly. 2012-09-10T18:51:09Z Nadav Rotem nrotem@apple.com 2012-09-10T18:51:09Z urn:sha1:6165dba25f3374ce340b420ab9a360623c26fdc3 git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@163530 91177308-0d34-0410-b5e6-96231b3b80d8 Stack Coloring: Add support for multiple regions of the same slot, within a single basic block. 2012-09-10T12:39:35Z Nadav Rotem nrotem@apple.com 2012-09-10T12:39:35Z urn:sha1:e47feeb823ebf496e82db6a666d4c0fbaeb158b4 git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@163507 91177308-0d34-0410-b5e6-96231b3b80d8 Teach the DAGBuilder about lifetime markers which are generated from PHINodes. 2012-09-10T08:43:23Z Nadav Rotem nrotem@apple.com 2012-09-10T08:43:23Z urn:sha1:9a2ae00c85c553108f3d57b134f0aceef5ae3372 git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@163494 91177308-0d34-0410-b5e6-96231b3b80d8 Disable stack coloring by default in order to resolve the i386 failures. 2012-09-06T14:27:06Z Nadav Rotem nrotem@apple.com 2012-09-06T14:27:06Z urn:sha1:79cb162e5d7aeaa3602bf4a7afa253232f461b33 git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@163316 91177308-0d34-0410-b5e6-96231b3b80d8 Fix the test by specifying an exact cpu model. 2012-09-06T10:33:33Z Nadav Rotem nrotem@apple.com 2012-09-06T10:33:33Z urn:sha1:a76d7d64a4aa39e459f0807143a95c2a1c046f9f git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@163307 91177308-0d34-0410-b5e6-96231b3b80d8 Add a new optimization pass: Stack Coloring, that merges disjoint static allocations (allocas). Allocas are known to be 2012-09-06T09:17:37Z Nadav Rotem nrotem@apple.com 2012-09-06T09:17:37Z urn:sha1:c05d30601ced172b55be81bb529df6be91d6ae15 disjoint if they are marked by disjoint lifetime markers (@llvm.lifetime.XXX intrinsics). git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@163299 91177308-0d34-0410-b5e6-96231b3b80d8