LLVM with the emscripten fastcomp javascript backend https://git.amat.us/emscripten-fastcomp/atom/lib/Bitcode/NaCl/Writer?h=1.12.1 2013-11-21T18:34:00Z 2013-11-21T18:34:00Z Karl Schimpf kschimpf@google.com 2013-11-21T18:34:00Z urn:sha1:7026af7138fccfb256456b04b375d39b025bdb7c Write out all of PNaCl bitcode headers using a single interface function. BUG= https://code.google.com/p/nativeclient/issues/detail?id=3720 R=jvoung@chromium.org Review URL: https://codereview.chromium.org/61753017 2013-11-21T17:55:24Z Karl Schimpf kschimpf@google.com 2013-11-21T17:55:24Z urn:sha1:86ff10150d76fa0db431a7c1c6db280f75977f35 The code previously was very inconsisted in modeling the number of bits needed for type ids within abbreviations. Frequently, the number of bits used was based on the total number of types. This is a bad choice in that this includes all function types, even though most cases do not use these types. This patch makes the selection more consistent. Also removing TYPE_CODE_ARRAY, since it is not allowed. BUG= https://code.google.com/p/nativeclient/issues/detail?id=3720 R=jvoung@chromium.org Review URL: https://codereview.chromium.org/68503018 2013-10-03T16:43:21Z Mark Seaborn mseaborn@chromium.org 2013-10-03T16:43:21Z urn:sha1:ed6b15283ff5f9d13cb48f88ba6e189be11291e8 The PNaCl bitcode writer had some complex logic for deciding when to omit casts in the output. This was left over from when the writer was trying to leave in the casts in some but not all cases (as part of incrementally removing casts). This is no longer needed now that the writer just omits all inttoptrs, all ptrtoints, and all pointer bitcasts. This cleanup also fixes the writer so that it elides an inttoptr of a ptrtoint. This sequence is allowed by the PNaCl ABI verifier, but never occurred in practice because ReplacePtrsWithInts' SimplifyCasts() function converts this sequence to an equivalent bitcast. Before this change, the writer would give this error for an inttoptr-of-ptrtoint: LLVM ERROR: Illegal (PNaCl ABI) pointer cast : %1 = ptrtoint [4 x i8]* @bytes to i32 BUG=https://code.google.com/p/nativeclient/issues/detail?id=3590 TEST=toolchain trybots Review URL: https://codereview.chromium.org/25817002 2013-10-03T15:08:25Z Mark Seaborn mseaborn@chromium.org 2013-10-03T15:08:25Z urn:sha1:8ed96f4d0ca9b8114875997f1f0196fc89a41a04 Make the reader and writer stricter so that we can be sure we're not accidentally generating ptrtoint or inttoptr instructions in pexe files. BUG=https://code.google.com/p/nativeclient/issues/detail?id=3590 TEST=toolchain trybots Review URL: https://codereview.chromium.org/25607006 2013-10-02T21:30:59Z Mark Seaborn mseaborn@chromium.org 2013-10-02T21:30:59Z urn:sha1:a85ac8f6999c04c5306efb5aa4fe77fc013c90e2 Declare NaClBitWriter's dependency on NaClBitReader. Without this change, pnacl-freeze fails at run time with: pnacl-freeze: symbol lookup error: .../native_client/pnacl/build/llvm_x86_64_ninja/lib/libLLVMNaClBitWriter.so: undefined symbol: _ZN4llvm17NaClBitcodeHeaderC1Ev BUG=none TEST=llvm-lit tests Review URL: https://codereview.chromium.org/24524003 2013-09-18T21:24:56Z Karl Schimpf kschimpf@google.com 2013-09-18T21:24:56Z urn:sha1:197cadba6026114ce62ed57dafe2125e70500a6b BUG= https://code.google.com/p/nativeclient/issues/detail?id=3590 R=mseaborn@chromium.org Review URL: https://codereview.chromium.org/24232002 2013-09-16T15:34:40Z Karl Schimpf kschimpf@google.com 2013-09-16T15:34:40Z urn:sha1:1d241cef755d5a129d3f17117c559a70ecaa0e0c BUG= https://code.google.com/p/nativeclient/issues/detail?id=3590 R=mseaborn@chromium.org Review URL: https://codereview.chromium.org/23974004 2013-09-09T17:32:47Z Mark Seaborn mseaborn@chromium.org 2013-09-09T17:32:47Z urn:sha1:b63e4bfe73188f7d68065f5b274e169491e593d2 There are now no uses of pointer type IDs in PNaCl bitcode, so we can stop outputting pointer types into the type table. BUG=https://code.google.com/p/nativeclient/issues/detail?id=3671 TEST=test/NaCl/Bitcode/*.ll Review URL: https://codereview.chromium.org/23600013 2013-09-09T17:06:19Z Mark Seaborn mseaborn@chromium.org 2013-09-09T17:06:19Z urn:sha1:1c0cea6c1fc807794f0d785392e05b19d0c70210 Before, FORWARDTYPEREFs used i8* type rather than i32 if they referenced an "alloca" instruction. Clean this up so that FORWARDTYPEREFs use i32 instead in this case. Note that this means that a forward-referenced "alloca" can be used via an ptrtoint+inttoptr, rather than a bitcast, but that's no problem. This is a step towards removing TYPE_CODE_POINTER from the types table, to simplify the PNaCl bitcode format. Rename NormalizeParamType() to NormalizeScalarType() to reflect that it's used in more cases; make it public. BUG=https://code.google.com/p/nativeclient/issues/detail?id=3671 TEST=test/NaCl/Bitcode/*.ll Review URL: https://codereview.chromium.org/23719016 2013-09-06T22:45:33Z Mark Seaborn mseaborn@chromium.org 2013-09-06T22:45:33Z urn:sha1:9ca910d4038b63e416311f7c4122de25c15cc5b0 BUG=none TEST=compile Review URL: https://codereview.chromium.org/23619020