From 481769b5dc102b0256b35581e787909ad5edfab5 Mon Sep 17 00:00:00 2001 From: Chris Lattner Date: Tue, 31 Mar 2009 22:17:44 +0000 Subject: remove some obsolete comments, use an AssertingVH. git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@68151 91177308-0d34-0410-b5e6-96231b3b80d8 --- lib/CodeGen/CodeGenModule.cpp | 11 ----------- 1 file changed, 11 deletions(-) (limited to 'lib/CodeGen/CodeGenModule.cpp') diff --git a/lib/CodeGen/CodeGenModule.cpp b/lib/CodeGen/CodeGenModule.cpp index 907ade569b..3de8156fe5 100644 --- a/lib/CodeGen/CodeGenModule.cpp +++ b/lib/CodeGen/CodeGenModule.cpp @@ -118,17 +118,6 @@ static void setGlobalVisibility(llvm::GlobalValue *GV, /// const char* containing the mangled name. Otherwise, returns /// the unmangled name. /// -/// FIXME: Returning an IdentifierInfo* here is a total hack. We -/// really need some kind of string abstraction that either stores a -/// mangled name or stores an IdentifierInfo*. This will require -/// changes to the GlobalDeclMap, too. (I disagree, I think what we -/// actually need is for Sema to provide some notion of which Decls -/// refer to the same semantic decl. We shouldn't need to mangle the -/// names and see what comes out the same to figure this out. - DWD) -/// -/// FIXME: Performance here is going to be terribly until we start -/// caching mangled names. However, we should fix the problem above -/// first. const char *CodeGenModule::getMangledName(const NamedDecl *ND) { // In C, functions with no attributes never need to be mangled. Fastpath them. if (!getLangOptions().CPlusPlus && !ND->hasAttrs()) { -- cgit v1.2.3-18-g5258