From 309457d0f1b416c1b379c9f3e172848adffedb23 Mon Sep 17 00:00:00 2001 From: Chris Lattner Date: Wed, 5 Aug 2009 04:56:58 +0000 Subject: rdar://7119244 - globals with an explicit section specified don't get common linkage. git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@78158 91177308-0d34-0410-b5e6-96231b3b80d8 --- lib/CodeGen/CodeGenModule.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) (limited to 'lib/CodeGen/CodeGenModule.cpp') diff --git a/lib/CodeGen/CodeGenModule.cpp b/lib/CodeGen/CodeGenModule.cpp index 08dc9930ba..95ce3e5d3a 100644 --- a/lib/CodeGen/CodeGenModule.cpp +++ b/lib/CodeGen/CodeGenModule.cpp @@ -883,7 +883,8 @@ void CodeGenModule::EmitGlobalVarDefinition(const VarDecl *D) { else if (D->hasAttr()) GV->setLinkage(llvm::GlobalVariable::WeakAnyLinkage); else if (!CompileOpts.NoCommon && - (!D->hasExternalStorage() && !D->getInit())) + !D->hasExternalStorage() && !D->getInit() && + !D->getAttr()) GV->setLinkage(llvm::GlobalVariable::CommonLinkage); else GV->setLinkage(llvm::GlobalVariable::ExternalLinkage); -- cgit v1.2.3-18-g5258