From 119f19b46b79cbe48f1992911588a728dfa5ad2e Mon Sep 17 00:00:00 2001 From: Fariborz Jahanian Date: Thu, 16 Jun 2011 14:49:42 +0000 Subject: Set the visibility to 'hidden' when previous declaration of global var is __private_extern__. // rdar://9609649 git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@133157 91177308-0d34-0410-b5e6-96231b3b80d8 --- lib/CodeGen/CodeGenModule.cpp | 13 +++++++++++-- 1 file changed, 11 insertions(+), 2 deletions(-) (limited to 'lib/CodeGen/CodeGenModule.cpp') diff --git a/lib/CodeGen/CodeGenModule.cpp b/lib/CodeGen/CodeGenModule.cpp index 78c57b4e3f..c15ef9b089 100644 --- a/lib/CodeGen/CodeGenModule.cpp +++ b/lib/CodeGen/CodeGenModule.cpp @@ -206,8 +206,17 @@ void CodeGenModule::setGlobalVisibility(llvm::GlobalValue *GV, // Set visibility for definitions. NamedDecl::LinkageInfo LV = D->getLinkageAndVisibility(); - if (LV.visibilityExplicit() || !GV->hasAvailableExternallyLinkage()) - GV->setVisibility(GetLLVMVisibility(LV.visibility())); + if (LV.visibilityExplicit() || !GV->hasAvailableExternallyLinkage()) { + Visibility Vis = LV.visibility(); + if (Vis == DefaultVisibility) + if (const VarDecl *VD = dyn_cast(D)) + if (const VarDecl *Old = VD->getPreviousDeclaration()) { + Visibility OldVis = Old->getLinkageAndVisibility().visibility(); + if (OldVis == HiddenVisibility) + Vis = HiddenVisibility; + } + GV->setVisibility(GetLLVMVisibility(Vis)); + } } /// Set the symbol visibility of type information (vtable and RTTI) -- cgit v1.2.3-18-g5258