From 0ffeaad72cb335b926b064379be4c9886bbff004 Mon Sep 17 00:00:00 2001 From: Anders Carlsson Date: Sat, 29 Jan 2011 19:39:23 +0000 Subject: Get rid of an unneeded parameter from setGlobalVisibility. git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@124541 91177308-0d34-0410-b5e6-96231b3b80d8 --- lib/CodeGen/CodeGenModule.cpp | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) (limited to 'lib/CodeGen/CodeGenModule.cpp') diff --git a/lib/CodeGen/CodeGenModule.cpp b/lib/CodeGen/CodeGenModule.cpp index 3162559e47..49c0b35df9 100644 --- a/lib/CodeGen/CodeGenModule.cpp +++ b/lib/CodeGen/CodeGenModule.cpp @@ -176,8 +176,7 @@ static llvm::GlobalValue::VisibilityTypes GetLLVMVisibility(Visibility V) { void CodeGenModule::setGlobalVisibility(llvm::GlobalValue *GV, - const NamedDecl *D, - bool IsForDefinition) const { + const NamedDecl *D) const { // Internal definitions always have default visibility. if (GV->hasLocalLinkage()) { GV->setVisibility(llvm::GlobalValue::DefaultVisibility); @@ -186,8 +185,7 @@ void CodeGenModule::setGlobalVisibility(llvm::GlobalValue *GV, // Set visibility for definitions. NamedDecl::LinkageInfo LV = D->getLinkageAndVisibility(); - if (LV.visibilityExplicit() || - (IsForDefinition && !GV->hasAvailableExternallyLinkage())) + if (LV.visibilityExplicit() || !GV->hasAvailableExternallyLinkage()) GV->setVisibility(GetLLVMVisibility(LV.visibility())); } @@ -196,7 +194,7 @@ void CodeGenModule::setGlobalVisibility(llvm::GlobalValue *GV, void CodeGenModule::setTypeVisibility(llvm::GlobalValue *GV, const CXXRecordDecl *RD, bool IsForRTTI) const { - setGlobalVisibility(GV, RD, /*IsForDefinition=*/true); + setGlobalVisibility(GV, RD); if (!CodeGenOpts.HiddenWeakVTables) return; @@ -460,7 +458,7 @@ void CodeGenModule::SetLLVMFunctionAttributesForDefinition(const Decl *D, void CodeGenModule::SetCommonAttributes(const Decl *D, llvm::GlobalValue *GV) { if (isa(D)) - setGlobalVisibility(GV, cast(D), /*ForDef*/ true); + setGlobalVisibility(GV, cast(D)); else GV->setVisibility(llvm::GlobalValue::DefaultVisibility); @@ -1415,7 +1413,7 @@ void CodeGenModule::EmitGlobalFunctionDefinition(GlobalDecl GD) { setFunctionLinkage(D, Fn); // FIXME: this is redundant with part of SetFunctionDefinitionAttributes - setGlobalVisibility(Fn, D, /*ForDef*/ true); + setGlobalVisibility(Fn, D); CodeGenFunction(*this).GenerateCode(D, Fn); -- cgit v1.2.3-18-g5258