From 03abc9ec05e8edce5e8d0c7f08a05027b9e04170 Mon Sep 17 00:00:00 2001 From: Daniel Dunbar Date: Tue, 7 Apr 2009 22:36:33 +0000 Subject: Visibility attributes should only be set on definition. git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@68561 91177308-0d34-0410-b5e6-96231b3b80d8 --- lib/CodeGen/CodeGenModule.cpp | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) (limited to 'lib/CodeGen/CodeGenModule.cpp') diff --git a/lib/CodeGen/CodeGenModule.cpp b/lib/CodeGen/CodeGenModule.cpp index 1dd2c4d67f..508d7ce2b6 100644 --- a/lib/CodeGen/CodeGenModule.cpp +++ b/lib/CodeGen/CodeGenModule.cpp @@ -272,10 +272,12 @@ void CodeGenModule::SetGlobalValueAttributes(const Decl *D, // FIXME: Figure out the relative priority of the attribute, // -fvisibility, and private_extern. - if (const VisibilityAttr *attr = D->getAttr()) - setGlobalVisibility(GV, attr->getVisibility()); - else - setGlobalOptionVisibility(GV, getLangOptions().getVisibilityMode()); + if (ForDefinition) { + if (const VisibilityAttr *attr = D->getAttr()) + setGlobalVisibility(GV, attr->getVisibility()); + else + setGlobalOptionVisibility(GV, getLangOptions().getVisibilityMode()); + } if (const SectionAttr *SA = D->getAttr()) GV->setSection(SA->getName()); -- cgit v1.2.3-18-g5258