diff options
Diffstat (limited to 'lib/StaticAnalyzer')
4 files changed, 7 insertions, 9 deletions
diff --git a/lib/StaticAnalyzer/Checkers/Checkers.td b/lib/StaticAnalyzer/Checkers/Checkers.td index 020cef1fbf..e2d11fedc2 100644 --- a/lib/StaticAnalyzer/Checkers/Checkers.td +++ b/lib/StaticAnalyzer/Checkers/Checkers.td @@ -78,6 +78,11 @@ def UnreachableCodeChecker : Checker<"UnreachableCode">, HelpText<"Check unreachable code">, DescFile<"UnreachableCodeChecker.cpp">; +def IdempotentOperationChecker : Checker<"IdempotentOps">, + InPackage<CoreExperimental>, + HelpText<"Warn about idempotent operations">, + DescFile<"IdempotentOperationChecker.cpp">; + def ChrootChecker : Checker<"Chroot">, InPackage<UnixExperimental>, HelpText<"Check improper use of chroot">, diff --git a/lib/StaticAnalyzer/Checkers/ExperimentalChecks.h b/lib/StaticAnalyzer/Checkers/ExperimentalChecks.h index aa87705105..1f38ad77eb 100644 --- a/lib/StaticAnalyzer/Checkers/ExperimentalChecks.h +++ b/lib/StaticAnalyzer/Checkers/ExperimentalChecks.h @@ -22,7 +22,6 @@ namespace ento { class ExprEngine; void RegisterAnalyzerStatsChecker(ExprEngine &Eng); -void RegisterIdempotentOperationChecker(ExprEngine &Eng); void RegisterMallocChecker(ExprEngine &Eng); } // end GR namespace diff --git a/lib/StaticAnalyzer/Checkers/IdempotentOperationChecker.cpp b/lib/StaticAnalyzer/Checkers/IdempotentOperationChecker.cpp index 2b0753649e..70d5a8b5f0 100644 --- a/lib/StaticAnalyzer/Checkers/IdempotentOperationChecker.cpp +++ b/lib/StaticAnalyzer/Checkers/IdempotentOperationChecker.cpp @@ -42,7 +42,7 @@ // - Finer grained false positive control (levels) // - Handling ~0 values -#include "ExperimentalChecks.h" +#include "ClangSACheckers.h" #include "clang/Analysis/CFGStmtMap.h" #include "clang/Analysis/Analyses/PseudoConstantAnalysis.h" #include "clang/StaticAnalyzer/Core/BugReporter/BugReporter.h" @@ -132,7 +132,7 @@ void *IdempotentOperationChecker::getTag() { return &x; } -void ento::RegisterIdempotentOperationChecker(ExprEngine &Eng) { +void ento::registerIdempotentOperationChecker(ExprEngine &Eng) { Eng.registerCheck(new IdempotentOperationChecker()); } diff --git a/lib/StaticAnalyzer/Frontend/AnalysisConsumer.cpp b/lib/StaticAnalyzer/Frontend/AnalysisConsumer.cpp index bbd7c6a5b3..588809f7a3 100644 --- a/lib/StaticAnalyzer/Frontend/AnalysisConsumer.cpp +++ b/lib/StaticAnalyzer/Frontend/AnalysisConsumer.cpp @@ -354,12 +354,6 @@ static void ActionExprEngine(AnalysisConsumer &C, AnalysisManager& mgr, if (C.Opts.EnableExperimentalChecks) RegisterExperimentalChecks(Eng); - // Enable idempotent operation checking if it was explicitly turned on, or if - // we are running experimental checks (i.e. everything) - if (C.Opts.IdempotentOps || C.Opts.EnableExperimentalChecks - || C.Opts.EnableExperimentalInternalChecks) - RegisterIdempotentOperationChecker(Eng); - if (C.Opts.BufferOverflows) RegisterArrayBoundCheckerV2(Eng); |