diff options
-rw-r--r-- | lib/CodeGen/CGExpr.cpp | 7 | ||||
-rw-r--r-- | lib/CodeGen/CGExprAgg.cpp | 11 | ||||
-rw-r--r-- | test/CodeGen/string-init.c | 8 |
3 files changed, 24 insertions, 2 deletions
diff --git a/lib/CodeGen/CGExpr.cpp b/lib/CodeGen/CGExpr.cpp index 840ed4314f..8d36c8e26d 100644 --- a/lib/CodeGen/CGExpr.cpp +++ b/lib/CodeGen/CGExpr.cpp @@ -395,9 +395,16 @@ LValue CodeGenFunction::EmitUnaryOpLValue(const UnaryOperator *E) { LValue CodeGenFunction::EmitStringLiteralLValue(const StringLiteral *E) { assert(!E->isWide() && "FIXME: Wide strings not supported yet!"); + // Get the string data const char *StrData = E->getStrData(); unsigned Len = E->getByteLength(); std::string StringLiteral(StrData, StrData+Len); + + // Resize the string to the right size + const ConstantArrayType *CAT = E->getType()->getAsConstantArrayType(); + uint64_t RealLen = CAT->getSize().getZExtValue(); + StringLiteral.resize(RealLen, '\0'); + return LValue::MakeAddr(CGM.GetAddrOfConstantString(StringLiteral)); } diff --git a/lib/CodeGen/CGExprAgg.cpp b/lib/CodeGen/CGExprAgg.cpp index 6b68705af7..c7c250ee7b 100644 --- a/lib/CodeGen/CGExprAgg.cpp +++ b/lib/CodeGen/CGExprAgg.cpp @@ -53,7 +53,7 @@ public: void EmitAggregateClear(llvm::Value *DestPtr, QualType Ty); void EmitNonConstInit(InitListExpr *E); - + //===--------------------------------------------------------------------===// // Visitor Methods //===--------------------------------------------------------------------===// @@ -336,7 +336,6 @@ void AggExprEmitter::EmitNullInitializationToLValue(LValue LV, QualType T) { } } - void AggExprEmitter::VisitInitListExpr(InitListExpr *E) { if (E->isConstantExpr(CGF.getContext(), 0)) { // FIXME: call into const expr emitter so that we can emit @@ -355,6 +354,14 @@ void AggExprEmitter::VisitInitListExpr(InitListExpr *E) { cast<llvm::ArrayType>(APType->getElementType()); uint64_t NumInitElements = E->getNumInits(); + + if (E->getNumInits() > 0 && + E->getType().getCanonicalType().getUnqualifiedType() == + E->getInit(0)->getType().getCanonicalType().getUnqualifiedType()) { + EmitAggLoadOfLValue(E->getInit(0)); + return; + } + uint64_t NumArrayElements = AType->getNumElements(); QualType ElementType = E->getType()->getAsArrayType()->getElementType(); diff --git a/test/CodeGen/string-init.c b/test/CodeGen/string-init.c new file mode 100644 index 0000000000..1d1a740faa --- /dev/null +++ b/test/CodeGen/string-init.c @@ -0,0 +1,8 @@ +// RUN: clang -emit-llvm %s -o - | not grep "[5 x i8]" +// RUN: clang -emit-llvm %s -o - | not grep "store" + +void test(void) { + char a[10] = "asdf"; + char b[10] = { "asdf" }; +} + |