diff options
| -rw-r--r-- | Sema/SemaDecl.cpp | 7 | ||||
| -rw-r--r-- | include/clang/AST/Decl.h | 1 |
2 files changed, 3 insertions, 5 deletions
diff --git a/Sema/SemaDecl.cpp b/Sema/SemaDecl.cpp index c427a81306..aba5b42192 100644 --- a/Sema/SemaDecl.cpp +++ b/Sema/SemaDecl.cpp @@ -527,11 +527,8 @@ bool Sema::CheckInitializerListTypes(InitListExpr*& IList, QualType &DeclType, } else { RecordDecl* structDecl = DeclType->getAsRecordType()->getDecl(); - // If the record is invalid, it's members can't be trusted. - // FIXME: I'd like to "fix" this at a higher level. That is, we should - // never get here if the struct decl is invalid. Considering a - // change to Type::isIncompleteType(). Until this happens, the - // following check is certainly better than crashing. + // If the record is invalid, some of it's members are invalid. To avoid + // confusion, we forgo checking the intializer for the entire record. if (structDecl->isInvalidDecl()) return true; diff --git a/include/clang/AST/Decl.h b/include/clang/AST/Decl.h index 07588e4c06..d72a5c80fc 100644 --- a/include/clang/AST/Decl.h +++ b/include/clang/AST/Decl.h @@ -705,6 +705,7 @@ protected: /// RecordDecl - Represents a struct/union/class. For example: /// struct X; // Forward declaration, no "body". /// union Y { int A, B; }; // Has body with members A and B (FieldDecls). +/// This decl will be marked invalid if *any* members are invalid. /// class RecordDecl : public TagDecl { /// HasFlexibleArrayMember - This is true if this struct ends with a flexible |