diff options
| -rw-r--r-- | lib/Sema/SemaStmt.cpp | 10 | ||||
| -rw-r--r-- | test/Sema/indirect-goto.c | 8 |
2 files changed, 15 insertions, 3 deletions
diff --git a/lib/Sema/SemaStmt.cpp b/lib/Sema/SemaStmt.cpp index 4ef0fda361..bbcc71d6e4 100644 --- a/lib/Sema/SemaStmt.cpp +++ b/lib/Sema/SemaStmt.cpp @@ -687,10 +687,14 @@ Sema::ActOnGotoStmt(SourceLocation GotoLoc, SourceLocation LabelLoc, Action::OwningStmtResult Sema::ActOnIndirectGotoStmt(SourceLocation GotoLoc,SourceLocation StarLoc, ExprArg DestExp) { - // FIXME: Verify that the operand is convertible to void*. // Convert operand to void* - Expr* E = (Expr*)DestExp.release(); - ImpCastExprToType(E, Context.VoidPtrTy); + Expr* E = DestExp.takeAs<Expr>(); + QualType ETy = E->getType(); + AssignConvertType ConvTy = + CheckSingleAssignmentConstraints(Context.VoidPtrTy, E); + if (DiagnoseAssignmentResult(ConvTy, StarLoc, Context.VoidPtrTy, ETy, + E, "passing")) + return StmtError(); return Owned(new (Context) IndirectGotoStmt(E)); } diff --git a/test/Sema/indirect-goto.c b/test/Sema/indirect-goto.c new file mode 100644 index 0000000000..35fb5e6315 --- /dev/null +++ b/test/Sema/indirect-goto.c @@ -0,0 +1,8 @@ +// RUN: clang-cc -fsyntax-only -verify %s + +struct c {int x;}; +int a(struct c x, long long y) { + goto *x; // expected-error{{incompatible type}} + goto *y; // expected-warning{{incompatible integer to pointer conversion}} +} + |