diff options
| -rw-r--r-- | bindings/python/clang/cindex.py | 2 | ||||
| -rw-r--r-- | bindings/python/tests/cindex/test_cdb.py | 8 |
2 files changed, 9 insertions, 1 deletions
diff --git a/bindings/python/clang/cindex.py b/bindings/python/clang/cindex.py index afbfe3d2ae..0aea4669e8 100644 --- a/bindings/python/clang/cindex.py +++ b/bindings/python/clang/cindex.py @@ -2162,7 +2162,7 @@ class CompileCommands(object): def __getitem__(self, i): cc = CompileCommands_getCommand(self.ccmds, i) - if cc is None: + if not cc: raise IndexError return CompileCommand(cc, self) diff --git a/bindings/python/tests/cindex/test_cdb.py b/bindings/python/tests/cindex/test_cdb.py index 38de4b1c14..374f99bcbf 100644 --- a/bindings/python/tests/cindex/test_cdb.py +++ b/bindings/python/tests/cindex/test_cdb.py @@ -61,6 +61,14 @@ def test_2_compilecommand(): for arg, exp in zip(cmds[i].arguments, expected[i]['line']): assert arg.spelling == exp +def test_compilecommand_iterator_stops(): + """Check that iterator stops after the correct number of elements""" + cdb = CompilationDatabase.fromDirectory(kInputsDir) + count = 0 + for cmd in cdb.getCompileCommands('/home/john.doe/MyProject/project2.cpp'): + count += 1 + assert count <= 2 + def test_compilationDB_references(): """Ensure CompilationsCommands are independent of the database""" cdb = CompilationDatabase.fromDirectory(kInputsDir) |