diff options
| -rw-r--r-- | lib/Lex/PPExpressions.cpp | 10 | ||||
| -rw-r--r-- | test/Lexer/number.c | 5 |
2 files changed, 8 insertions, 7 deletions
diff --git a/lib/Lex/PPExpressions.cpp b/lib/Lex/PPExpressions.cpp index 5f11df0893..2a4794de83 100644 --- a/lib/Lex/PPExpressions.cpp +++ b/lib/Lex/PPExpressions.cpp @@ -198,7 +198,8 @@ static bool EvaluateValue(PPValue &Result, Token &PeekTok, DefinedTracker &DT, // large that it is unsigned" e.g. on 12345678901234567890 where intmax_t // is 64-bits. if (!Literal.isUnsigned && Result.Val.isNegative()) { - if (ValueLive) + // Don't warn for a hex literal: 0x8000..0 shouldn't warn. + if (ValueLive && Literal.getRadix() != 16) PP.Diag(PeekTok, diag::warn_integer_too_large_for_signed); Result.Val.setIsUnsigned(true); } @@ -288,11 +289,8 @@ static bool EvaluateValue(PPValue &Result, Token &PeekTok, DefinedTracker &DT, // C99 6.5.3.3p3: The sign of the result matches the sign of the operand. Result.Val = -Result.Val; - bool Overflow = false; - if (Result.isUnsigned()) - Overflow = Result.Val.isNegative(); - else if (Result.Val.isMinSignedValue()) - Overflow = true; // -MININT is the only thing that overflows. + // -MININT is the only thing that overflows. Unsigned never overflows. + bool Overflow = !Result.isUnsigned() && Result.Val.isMinSignedValue(); // If this operator is live and overflowed, report the issue. if (Overflow && ValueLive) diff --git a/test/Lexer/number.c b/test/Lexer/number.c index e48816e405..bafbc022d5 100644 --- a/test/Lexer/number.c +++ b/test/Lexer/number.c @@ -1,6 +1,9 @@ // RUN: clang %s -fsyntax-only float X = 1.17549435e-38F; - float Y = 08.123456; +// PR2252 +#if -0x8000000000000000 // should not warn. +#endif + |