diff options
-rw-r--r-- | include/clang/AST/LambdaMangleContext.h | 3 | ||||
-rw-r--r-- | include/clang/Sema/Sema.h | 6 | ||||
-rw-r--r-- | test/SemaCXX/crash-lambda-12645424.cpp | 43 |
3 files changed, 46 insertions, 6 deletions
diff --git a/include/clang/AST/LambdaMangleContext.h b/include/clang/AST/LambdaMangleContext.h index 3e2fbad2f8..d686365335 100644 --- a/include/clang/AST/LambdaMangleContext.h +++ b/include/clang/AST/LambdaMangleContext.h @@ -15,6 +15,7 @@ #define LLVM_CLANG_LAMBDAMANGLECONTEXT_H #include "llvm/ADT/DenseMap.h" +#include "llvm/ADT/IntrusiveRefCntPtr.h" namespace clang { @@ -23,7 +24,7 @@ class FunctionProtoType; /// \brief Keeps track of the mangled names of lambda expressions within a /// particular context. -class LambdaMangleContext { +class LambdaMangleContext : public llvm::RefCountedBase<LambdaMangleContext> { llvm::DenseMap<const FunctionProtoType *, unsigned> ManglingNumbers; public: diff --git a/include/clang/Sema/Sema.h b/include/clang/Sema/Sema.h index 2b1f4b5067..16de280d72 100644 --- a/include/clang/Sema/Sema.h +++ b/include/clang/Sema/Sema.h @@ -635,7 +635,7 @@ public: /// /// This mangling information is allocated lazily, since most contexts /// do not have lambda expressions. - LambdaMangleContext *LambdaMangle; + IntrusiveRefCntPtr<LambdaMangleContext> LambdaMangle; /// \brief If we are processing a decltype type, a set of call expressions /// for which we have deferred checking the completeness of the return type. @@ -654,10 +654,6 @@ public: IsDecltype(IsDecltype), NumCleanupObjects(NumCleanupObjects), LambdaContextDecl(LambdaContextDecl), LambdaMangle() { } - ~ExpressionEvaluationContextRecord() { - delete LambdaMangle; - } - /// \brief Retrieve the mangling context for lambdas. LambdaMangleContext &getLambdaMangleContext() { assert(LambdaContextDecl && "Need to have a lambda context declaration"); diff --git a/test/SemaCXX/crash-lambda-12645424.cpp b/test/SemaCXX/crash-lambda-12645424.cpp new file mode 100644 index 0000000000..8317e7c0db --- /dev/null +++ b/test/SemaCXX/crash-lambda-12645424.cpp @@ -0,0 +1,43 @@ +// RUN: %clang_cc1 -fsyntax-only -std=c++11 %s -verify + +// rdar://12645424, crash due to a double-free + +template<typename _Tp> struct __add_lvalue_reference_helper {}; +template<typename _Tp> struct add_lvalue_reference : __add_lvalue_reference_helper<_Tp> { + typedef _Tp type; +}; + +template<typename... Types> struct type_list; +template<typename , template<typename> class... Funs> struct C; + +template<typename T> struct C<T> { + typedef T type; +}; + +template<typename T, template<typename> class Fun0, template<typename> class... Funs> struct C<T, Fun0, Funs...> { + typedef typename C<typename Fun0<T>::type, Funs...>::type type; +}; + +template<class , template<typename> class... Funs> struct tl_map; +template<typename... Ts, template<typename> class... Funs> struct tl_map<type_list<Ts...>, Funs...> { + typedef type_list<typename C<Ts, Funs...>::type...> type; +}; + +template< class Pattern> struct F { + typedef Pattern filtered_pattern; + tl_map< filtered_pattern, add_lvalue_reference > type; +}; + +template<class, class Pattern> struct get_case { + F<Pattern> type; +}; + +template<class Pattern> struct rvalue_builder { + template<typename Expr> typename get_case<Expr, Pattern>::type operator>>(Expr ); // expected-note {{candidate template ignored}} +}; + +template<typename Arg0> rvalue_builder< type_list<Arg0> > on(const Arg0& ) ; + +class Z { + int empty = on(0) >> [] {}; // expected-error {{invalid operands to binary expression}} +}; |