diff options
| -rw-r--r-- | lib/StaticAnalyzer/Checkers/DeadStoresChecker.cpp | 9 | ||||
| -rw-r--r-- | test/Analysis/dead-stores.cpp | 18 |
2 files changed, 27 insertions, 0 deletions
diff --git a/lib/StaticAnalyzer/Checkers/DeadStoresChecker.cpp b/lib/StaticAnalyzer/Checkers/DeadStoresChecker.cpp index e2f8395da9..f2e3e6d781 100644 --- a/lib/StaticAnalyzer/Checkers/DeadStoresChecker.cpp +++ b/lib/StaticAnalyzer/Checkers/DeadStoresChecker.cpp @@ -419,6 +419,15 @@ class DeadStoresChecker : public Checker<check::ASTCodeBody> { public: void checkASTCodeBody(const Decl *D, AnalysisManager& mgr, BugReporter &BR) const { + + // Don't do anything for template instantiations. + // Proving that code in a template instantiation is "dead" + // means proving that it is dead in all instantiations. + // This same problem exists with -Wunreachable-code. + if (const FunctionDecl *FD = dyn_cast<FunctionDecl>(D)) + if (FD->isTemplateInstantiation()) + return; + if (LiveVariables *L = mgr.getAnalysis<LiveVariables>(D)) { CFG &cfg = *mgr.getCFG(D); AnalysisDeclContext *AC = mgr.getAnalysisDeclContext(D); diff --git a/test/Analysis/dead-stores.cpp b/test/Analysis/dead-stores.cpp index e1a034b1d0..d442c621d8 100644 --- a/test/Analysis/dead-stores.cpp +++ b/test/Analysis/dead-stores.cpp @@ -156,3 +156,21 @@ void testCXX11Using() { Int value; value = 1; // expected-warning {{never read}} } + +//===----------------------------------------------------------------------===// +// Dead stores in template instantiations (do not warn). +//===----------------------------------------------------------------------===// + +template <bool f> int radar13213575_testit(int i) { + int x = 5+i; // warning: Value stored to 'x' during its initialization is never read + int y = 7; + if (f) + return x; + else + return y; +} + +int radar_13213575() { + return radar13213575_testit<true>(5) + radar13213575_testit<false>(3); +} + |