diff options
| -rw-r--r-- | lib/Sema/SemaDeclAttr.cpp | 4 | ||||
| -rw-r--r-- | test/SemaObjC/objc-gc-attr.m | 8 |
2 files changed, 10 insertions, 2 deletions
diff --git a/lib/Sema/SemaDeclAttr.cpp b/lib/Sema/SemaDeclAttr.cpp index 2cfb3b9b96..f94711e987 100644 --- a/lib/Sema/SemaDeclAttr.cpp +++ b/lib/Sema/SemaDeclAttr.cpp @@ -467,7 +467,7 @@ static void HandleVisibilityAttr(Decl *d, const AttributeList &Attr, Sema &S) { } static void HandleObjCGCAttr(Decl *d, const AttributeList &Attr, Sema &S) { - if (!Attr.getParameterName()) { + if (!Attr.getParameterName()) { S.Diag(Attr.getLoc(), diag::err_attribute_argument_n_not_string, "objc_gc", std::string("1")); return; @@ -486,7 +486,7 @@ static void HandleObjCGCAttr(Decl *d, const AttributeList &Attr, Sema &S) { if (TypeLen == 4 && !memcmp(TypeStr, "weak", 4)) type = ObjCGCAttr::Weak; - else if (TypeLen == 5 && !memcmp(TypeStr, "strong", 5)) + else if (TypeLen == 6 && !memcmp(TypeStr, "strong", 6)) type = ObjCGCAttr::Strong; else { S.Diag(Attr.getLoc(), diag::warn_attribute_type_not_supported, diff --git a/test/SemaObjC/objc-gc-attr.m b/test/SemaObjC/objc-gc-attr.m new file mode 100644 index 0000000000..1f2db346a1 --- /dev/null +++ b/test/SemaObjC/objc-gc-attr.m @@ -0,0 +1,8 @@ +// RUN: clang -fsyntax-only -verify %s +static id __attribute((objc_gc(weak))) a; +static id __attribute((objc_gc(strong))) b; + +static id __attribute((objc_gc())) c; // expected-error{{'objc_gc' attribute requires parameter 1 to be a string}} +static id __attribute((objc_gc(123))) d; // expected-error{{'objc_gc' attribute requires parameter 1 to be a string}} +static id __attribute((objc_gc(foo, 456))) e; // expected-error{{attribute requires 1 argument(s)}} +static id __attribute((objc_gc(hello))) f; // expected-warning{{'objc_gc' attribute argument not supported: 'hello'}} |