diff options
-rw-r--r-- | lib/Analysis/CFRefCount.cpp | 14 | ||||
-rw-r--r-- | test/Analysis/retain-release.m | 12 |
2 files changed, 23 insertions, 3 deletions
diff --git a/lib/Analysis/CFRefCount.cpp b/lib/Analysis/CFRefCount.cpp index c8919c38cb..d3d0545e99 100644 --- a/lib/Analysis/CFRefCount.cpp +++ b/lib/Analysis/CFRefCount.cpp @@ -1267,15 +1267,23 @@ RetainSummaryManager::updateSummaryFromAnnotations(RetainSummary &Summ, if (!MD) return; + bool isTrackedLoc = false; + // Determine if there is a special return effect for this method. if (isTrackedObjCObjectType(MD->getResultType())) { if (MD->getAttr<NSReturnsRetainedAttr>()) { Summ.setRetEffect(ObjCAllocRetE); + return; } - else if (MD->getAttr<CFReturnsRetainedAttr>()) { - Summ.setRetEffect(RetEffect::MakeOwned(RetEffect::CF, true)); - } + + isTrackedLoc = true; } + + if (!isTrackedLoc) + isTrackedLoc = MD->getResultType()->getAsPointerType() != NULL; + + if (isTrackedLoc && MD->getAttr<CFReturnsRetainedAttr>()) + Summ.setRetEffect(RetEffect::MakeOwned(RetEffect::CF, true)); } RetainSummary* diff --git a/test/Analysis/retain-release.m b/test/Analysis/retain-release.m index da0ae801da..63470146bb 100644 --- a/test/Analysis/retain-release.m +++ b/test/Analysis/retain-release.m @@ -815,7 +815,9 @@ void test_attr_1b(TestOwnershipAttr *X) { @interface MyClassTestCFAttr : NSObject {} - (NSDate*) returnsCFRetained __attribute__((cf_returns_retained)); +- (CFDateRef) returnsCFRetainedAsCF __attribute__((cf_returns_retained)); - (NSDate*) alsoReturnsRetained; +- (CFDateRef) alsoReturnsRetainedAsCF; - (NSDate*) returnsNSRetained __attribute__((ns_returns_retained)); @end @@ -829,10 +831,20 @@ CFDateRef returnsRetainedCFDate() { return (NSDate*) returnsRetainedCFDate(); // No leak. } +- (CFDateRef) returnsCFRetainedAsCF { + return returnsRetainedCFDate(); // No leak. +} + + - (NSDate*) alsoReturnsRetained { return (NSDate*) returnsRetainedCFDate(); // expected-warning{{leak}} } +- (CFDateRef) alsoReturnsRetainedAsCF { + return returnsRetainedCFDate(); // expected-warning{{leak}} +} + + - (NSDate*) returnsNSRetained { return (NSDate*) returnsRetainedCFDate(); // no-warning } |