diff options
| -rw-r--r-- | lib/StaticAnalyzer/Core/CFRefCount.cpp | 12 | ||||
| -rw-r--r-- | test/Analysis/idempotent-operations.m | 34 |
2 files changed, 46 insertions, 0 deletions
diff --git a/lib/StaticAnalyzer/Core/CFRefCount.cpp b/lib/StaticAnalyzer/Core/CFRefCount.cpp index 09e69239d6..92bd4116a7 100644 --- a/lib/StaticAnalyzer/Core/CFRefCount.cpp +++ b/lib/StaticAnalyzer/Core/CFRefCount.cpp @@ -2514,6 +2514,18 @@ void CFRefCount::evalSummary(ExplodedNodeSet& Dst, // done an invalidation pass. llvm::DenseSet<SymbolRef> WhitelistedSymbols; + // Invalidate all instance variables of the receiver of a message. + // FIXME: We should be able to do better with inter-procedural analysis. + if (Receiver) { + SVal V = Receiver.getSValAsScalarOrLoc(state); + if (SymbolRef Sym = V.getAsLocSymbol()) { + if (state->get<RefBindings>(Sym)) + WhitelistedSymbols.insert(Sym); + } + if (const MemRegion *region = V.getAsRegion()) + RegionsToInvalidate.push_back(region); + } + for (unsigned idx = 0, e = callOrMsg.getNumArgs(); idx != e; ++idx) { SVal V = callOrMsg.getArgSValAsScalarOrLoc(idx); SymbolRef Sym = V.getAsLocSymbol(); diff --git a/test/Analysis/idempotent-operations.m b/test/Analysis/idempotent-operations.m new file mode 100644 index 0000000000..3f68206b16 --- /dev/null +++ b/test/Analysis/idempotent-operations.m @@ -0,0 +1,34 @@ +// RUN: %clang_cc1 -analyze -analyzer-store=region -analyzer-constraints=range -fblocks -analyzer-opt-analyze-nested-blocks -analyzer-check-objc-mem -analyzer-check-idempotent-operations -verify %s + +typedef signed char BOOL; +typedef unsigned long NSUInteger; +typedef struct _NSZone NSZone; +@protocol NSObject - (BOOL)isEqual:(id)object; +@end @interface NSObject <NSObject> { +} +@end + + +// <rdar://problem/8725041> - Don't flag idempotent operation warnings when +// a method may invalidate an instance variable. +@interface Rdar8725041 : NSObject { + id _attribute; +} + - (void) method2; +@end + +@implementation Rdar8725041 +- (BOOL) method1 { + BOOL needsUpdate = (BOOL)0; + id oldAttribute = _attribute; + [self method2]; + needsUpdate |= (_attribute != oldAttribute); // no-warning + return needsUpdate; +} + +- (void) method2 +{ + _attribute = ((void*)0); +} +@end + |