diff options
| -rw-r--r-- | lib/AST/Expr.cpp | 5 | ||||
| -rw-r--r-- | test/SemaCXX/warn-unused-value.cpp | 15 |
2 files changed, 19 insertions, 1 deletions
diff --git a/lib/AST/Expr.cpp b/lib/AST/Expr.cpp index 8beecc0856..7983d61f04 100644 --- a/lib/AST/Expr.cpp +++ b/lib/AST/Expr.cpp @@ -1631,8 +1631,11 @@ bool Expr::isUnusedResultAWarning(SourceLocation &Loc, SourceRange &R1, // DiagnoseUnusedComparison should be as well. const CXXOperatorCallExpr *Op = cast<CXXOperatorCallExpr>(this); if (Op->getOperator() == OO_EqualEqual || - Op->getOperator() == OO_ExclaimEqual) + Op->getOperator() == OO_ExclaimEqual) { + Loc = Op->getOperatorLoc(); + R1 = Op->getSourceRange(); return true; + } // Fallthrough for generic call handling. } diff --git a/test/SemaCXX/warn-unused-value.cpp b/test/SemaCXX/warn-unused-value.cpp index 775c3cf01f..80298ec666 100644 --- a/test/SemaCXX/warn-unused-value.cpp +++ b/test/SemaCXX/warn-unused-value.cpp @@ -15,3 +15,18 @@ namespace test0 { box->j; } } + +namespace test1 { +struct Foo { + int i; + bool operator==(const Foo& rhs) { + return i == rhs.i; + } +}; + +#define NOP(x) (x) +void b(Foo f1, Foo f2) { + NOP(f1 == f2); // expected-warning {{expression result unused}} +} +#undef NOP +} |