diff options
| author | Anna Zaks <ganna@apple.com> | 2012-08-29 21:22:37 +0000 |
|---|---|---|
| committer | Anna Zaks <ganna@apple.com> | 2012-08-29 21:22:37 +0000 |
| commit | 80de487e03dd0f44e4572e2122ebc1aa6a3961f5 (patch) | |
| tree | 4388c41e6efe5f7600ba369e668d157102adf1a1 /test/Analysis/diagnostics/undef-value-param.c | |
| parent | a484fc73ec6331bcaad092270b4ab9c8d1df23c3 (diff) | |
[analyzer] Improved diagnostic pruning for calls initializing values.
This heuristic addresses the case when a pointer (or ref) is passed
to a function, which initializes the variable (or sets it to something
other than '0'). On the branch where the inlined function does not
set the value, we report use of undefined value (or NULL pointer
dereference). The access happens in the caller and the path
through the callee would get pruned away with regular path pruning. To
solve this issue, we previously disabled diagnostic pruning completely
on undefined and null pointer dereference checks, which entailed very
verbose diagnostics in most cases. Furthermore, not all of the
undef value checks had the diagnostic pruning disabled.
This patch implements the following heuristic: if we pass a pointer (or
ref) to the region (on which the error is reported) into a function and
it's value is either undef or 'NULL' (and is a pointer), do not prune
the function.
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@162863 91177308-0d34-0410-b5e6-96231b3b80d8
Diffstat (limited to 'test/Analysis/diagnostics/undef-value-param.c')
| -rw-r--r-- | test/Analysis/diagnostics/undef-value-param.c | 451 |
1 files changed, 451 insertions, 0 deletions
diff --git a/test/Analysis/diagnostics/undef-value-param.c b/test/Analysis/diagnostics/undef-value-param.c new file mode 100644 index 0000000000..94fbb11c9e --- /dev/null +++ b/test/Analysis/diagnostics/undef-value-param.c @@ -0,0 +1,451 @@ +// RUN: %clang_cc1 -analyze -analyzer-checker=core -analyzer-output=text -verify %s +// RUN: %clang_cc1 -analyze -analyzer-checker=core -analyzer-output=plist-multi-file %s -o - | FileCheck %s + +void foo_irrelevant(int c) { + if (c) + return; + c++; + return; +} +void foo(int *x, int c) { + if (c) + //expected-note@-1{{Assuming 'c' is not equal to 0}} + //expected-note@-2{{Taking true branch}} + return; + *x = 5; +} + +int use(int c) { + int xx; //expected-note{{Variable 'xx' declared without an initial value}} + int *y = &xx; + foo (y, c); + //expected-note@-1{{Calling 'foo'}} + //expected-note@-2{{Returning from 'foo'}} + foo_irrelevant(c); + return xx+3; //expected-warning{{The left operand of '+' is a garbage value}} + //expected-note@-1{{The left operand of '+' is a garbage value}} +} + +//CHECK: <dict> +//CHECK: <key>files</key> +//CHECK: <array> +//CHECK: </array> +//CHECK: <key>diagnostics</key> +//CHECK: <array> +//CHECK: <dict> +//CHECK: <key>path</key> +//CHECK: <array> +//CHECK: <dict> +//CHECK: <key>kind</key><string>event</string> +//CHECK: <key>location</key> +//CHECK: <dict> +//CHECK: <key>line</key><integer>19</integer> +//CHECK: <key>col</key><integer>5</integer> +//CHECK: <key>file</key><integer>0</integer> +//CHECK: </dict> +//CHECK: <key>ranges</key> +//CHECK: <array> +//CHECK: <array> +//CHECK: <dict> +//CHECK: <key>line</key><integer>19</integer> +//CHECK: <key>col</key><integer>5</integer> +//CHECK: <key>file</key><integer>0</integer> +//CHECK: </dict> +//CHECK: <dict> +//CHECK: <key>line</key><integer>19</integer> +//CHECK: <key>col</key><integer>10</integer> +//CHECK: <key>file</key><integer>0</integer> +//CHECK: </dict> +//CHECK: </array> +//CHECK: </array> +//CHECK: <key>depth</key><integer>0</integer> +//CHECK: <key>extended_message</key> +//CHECK: <string>Variable 'xx' declared without an initial value</string> +//CHECK: <key>message</key> +//CHECK: <string>Variable 'xx' declared without an initial value</string> +//CHECK: </dict> +//CHECK: <dict> +//CHECK: <key>kind</key><string>control</string> +//CHECK: <key>edges</key> +//CHECK: <array> +//CHECK: <dict> +//CHECK: <key>start</key> +//CHECK: <array> +//CHECK: <dict> +//CHECK: <key>line</key><integer>19</integer> +//CHECK: <key>col</key><integer>5</integer> +//CHECK: <key>file</key><integer>0</integer> +//CHECK: </dict> +//CHECK: <dict> +//CHECK: <key>line</key><integer>19</integer> +//CHECK: <key>col</key><integer>7</integer> +//CHECK: <key>file</key><integer>0</integer> +//CHECK: </dict> +//CHECK: </array> +//CHECK: <key>end</key> +//CHECK: <array> +//CHECK: <dict> +//CHECK: <key>line</key><integer>21</integer> +//CHECK: <key>col</key><integer>5</integer> +//CHECK: <key>file</key><integer>0</integer> +//CHECK: </dict> +//CHECK: <dict> +//CHECK: <key>line</key><integer>21</integer> +//CHECK: <key>col</key><integer>7</integer> +//CHECK: <key>file</key><integer>0</integer> +//CHECK: </dict> +//CHECK: </array> +//CHECK: </dict> +//CHECK: </array> +//CHECK: </dict> +//CHECK: <dict> +//CHECK: <key>kind</key><string>event</string> +//CHECK: <key>location</key> +//CHECK: <dict> +//CHECK: <key>line</key><integer>21</integer> +//CHECK: <key>col</key><integer>5</integer> +//CHECK: <key>file</key><integer>0</integer> +//CHECK: </dict> +//CHECK: <key>ranges</key> +//CHECK: <array> +//CHECK: <array> +//CHECK: <dict> +//CHECK: <key>line</key><integer>21</integer> +//CHECK: <key>col</key><integer>5</integer> +//CHECK: <key>file</key><integer>0</integer> +//CHECK: </dict> +//CHECK: <dict> +//CHECK: <key>line</key><integer>21</integer> +//CHECK: <key>col</key><integer>14</integer> +//CHECK: <key>file</key><integer>0</integer> +//CHECK: </dict> +//CHECK: </array> +//CHECK: </array> +//CHECK: <key>depth</key><integer>0</integer> +//CHECK: <key>extended_message</key> +//CHECK: <string>Calling 'foo'</string> +//CHECK: <key>message</key> +//CHECK: <string>Calling 'foo'</string> +//CHECK: </dict> +//CHECK: <dict> +//CHECK: <key>kind</key><string>event</string> +//CHECK: <key>location</key> +//CHECK: <dict> +//CHECK: <key>line</key><integer>10</integer> +//CHECK: <key>col</key><integer>1</integer> +//CHECK: <key>file</key><integer>0</integer> +//CHECK: </dict> +//CHECK: <key>depth</key><integer>1</integer> +//CHECK: <key>extended_message</key> +//CHECK: <string>Entered call from 'use'</string> +//CHECK: <key>message</key> +//CHECK: <string>Entered call from 'use'</string> +//CHECK: </dict> +//CHECK: <dict> +//CHECK: <key>kind</key><string>control</string> +//CHECK: <key>edges</key> +//CHECK: <array> +//CHECK: <dict> +//CHECK: <key>start</key> +//CHECK: <array> +//CHECK: <dict> +//CHECK: <key>line</key><integer>10</integer> +//CHECK: <key>col</key><integer>1</integer> +//CHECK: <key>file</key><integer>0</integer> +//CHECK: </dict> +//CHECK: <dict> +//CHECK: <key>line</key><integer>10</integer> +//CHECK: <key>col</key><integer>4</integer> +//CHECK: <key>file</key><integer>0</integer> +//CHECK: </dict> +//CHECK: </array> +//CHECK: <key>end</key> +//CHECK: <array> +//CHECK: <dict> +//CHECK: <key>line</key><integer>11</integer> +//CHECK: <key>col</key><integer>5</integer> +//CHECK: <key>file</key><integer>0</integer> +//CHECK: </dict> +//CHECK: <dict> +//CHECK: <key>line</key><integer>11</integer> +//CHECK: <key>col</key><integer>6</integer> +//CHECK: <key>file</key><integer>0</integer> +//CHECK: </dict> +//CHECK: </array> +//CHECK: </dict> +//CHECK: </array> +//CHECK: </dict> +//CHECK: <dict> +//CHECK: <key>kind</key><string>control</string> +//CHECK: <key>edges</key> +//CHECK: <array> +//CHECK: <dict> +//CHECK: <key>start</key> +//CHECK: <array> +//CHECK: <dict> +//CHECK: <key>line</key><integer>11</integer> +//CHECK: <key>col</key><integer>5</integer> +//CHECK: <key>file</key><integer>0</integer> +//CHECK: </dict> +//CHECK: <dict> +//CHECK: <key>line</key><integer>11</integer> +//CHECK: <key>col</key><integer>6</integer> +//CHECK: <key>file</key><integer>0</integer> +//CHECK: </dict> +//CHECK: </array> +//CHECK: <key>end</key> +//CHECK: <array> +//CHECK: <dict> +//CHECK: <key>line</key><integer>11</integer> +//CHECK: <key>col</key><integer>9</integer> +//CHECK: <key>file</key><integer>0</integer> +//CHECK: </dict> +//CHECK: <dict> +//CHECK: <key>line</key><integer>11</integer> +//CHECK: <key>col</key><integer>9</integer> +//CHECK: <key>file</key><integer>0</integer> +//CHECK: </dict> +//CHECK: </array> +//CHECK: </dict> +//CHECK: </array> +//CHECK: </dict> +//CHECK: <dict> +//CHECK: <key>kind</key><string>event</string> +//CHECK: <key>location</key> +//CHECK: <dict> +//CHECK: <key>line</key><integer>11</integer> +//CHECK: <key>col</key><integer>9</integer> +//CHECK: <key>file</key><integer>0</integer> +//CHECK: </dict> +//CHECK: <key>ranges</key> +//CHECK: <array> +//CHECK: <array> +//CHECK: <dict> +//CHECK: <key>line</key><integer>11</integer> +//CHECK: <key>col</key><integer>9</integer> +//CHECK: <key>file</key><integer>0</integer> +//CHECK: </dict> +//CHECK: <dict> +//CHECK: <key>line</key><integer>11</integer> +//CHECK: <key>col</key><integer>9</integer> +//CHECK: <key>file</key><integer>0</integer> +//CHECK: </dict> +//CHECK: </array> +//CHECK: </array> +//CHECK: <key>depth</key><integer>1</integer> +//CHECK: <key>extended_message</key> +//CHECK: <string>Assuming 'c' is not equal to 0</string> +//CHECK: <key>message</key> +//CHECK: <string>Assuming 'c' is not equal to 0</string> +//CHECK: </dict> +//CHECK: <dict> +//CHECK: <key>kind</key><string>control</string> +//CHECK: <key>edges</key> +//CHECK: <array> +//CHECK: <dict> +//CHECK: <key>start</key> +//CHECK: <array> +//CHECK: <dict> +//CHECK: <key>line</key><integer>11</integer> +//CHECK: <key>col</key><integer>9</integer> +//CHECK: <key>file</key><integer>0</integer> +//CHECK: </dict> +//CHECK: <dict> +//CHECK: <key>line</key><integer>11</integer> +//CHECK: <key>col</key><integer>9</integer> +//CHECK: <key>file</key><integer>0</integer> +//CHECK: </dict> +//CHECK: </array> +//CHECK: <key>end</key> +//CHECK: <array> +//CHECK: <dict> +//CHECK: <key>line</key><integer>14</integer> +//CHECK: <key>col</key><integer>9</integer> +//CHECK: <key>file</key><integer>0</integer> +//CHECK: </dict> +//CHECK: <dict> +//CHECK: <key>line</key><integer>14</integer> +//CHECK: <key>col</key><integer>14</integer> +//CHECK: <key>file</key><integer>0</integer> +//CHECK: </dict> +//CHECK: </array> +//CHECK: </dict> +//CHECK: </array> +//CHECK: </dict> +//CHECK: <dict> +//CHECK: <key>kind</key><string>event</string> +//CHECK: <key>location</key> +//CHECK: <dict> +//CHECK: <key>line</key><integer>21</integer> +//CHECK: <key>col</key><integer>5</integer> +//CHECK: <key>file</key><integer>0</integer> +//CHECK: </dict> +//CHECK: <key>ranges</key> +//CHECK: <array> +//CHECK: <array> +//CHECK: <dict> +//CHECK: <key>line</key><integer>21</integer> +//CHECK: <key>col</key><integer>5</integer> +//CHECK: <key>file</key><integer>0</integer> +//CHECK: </dict> +//CHECK: <dict> +//CHECK: <key>line</key><integer>21</integer> +//CHECK: <key>col</key><integer>14</integer> +//CHECK: <key>file</key><integer>0</integer> +//CHECK: </dict> +//CHECK: </array> +//CHECK: </array> +//CHECK: <key>depth</key><integer>1</integer> +//CHECK: <key>extended_message</key> +//CHECK: <string>Returning from 'foo'</string> +//CHECK: <key>message</key> +//CHECK: <string>Returning from 'foo'</string> +//CHECK: </dict> +//CHECK: <dict> +//CHECK: <key>kind</key><string>control</string> +//CHECK: <key>edges</key> +//CHECK: <array> +//CHECK: <dict> +//CHECK: <key>start</key> +//CHECK: <array> +//CHECK: <dict> +//CHECK: <key>line</key><integer>21</integer> +//CHECK: <key>col</key><integer>5</integer> +//CHECK: <key>file</key><integer>0</integer> +//CHECK: </dict> +//CHECK: <dict> +//CHECK: <key>line</key><integer>21</integer> +//CHECK: <key>col</key><integer>7</integer> +//CHECK: <key>file</key><integer>0</integer> +//CHECK: </dict> +//CHECK: </array> +//CHECK: <key>end</key> +//CHECK: <array> +//CHECK: <dict> +//CHECK: <key>line</key><integer>24</integer> +//CHECK: <key>col</key><integer>5</integer> +//CHECK: <key>file</key><integer>0</integer> +//CHECK: </dict> +//CHECK: <dict> +//CHECK: <key>line</key><integer>24</integer> +//CHECK: <key>col</key><integer>18</integer> +//CHECK: <key>file</key><integer>0</integer> +//CHECK: </dict> +//CHECK: </array> +//CHECK: </dict> +//CHECK: </array> +//CHECK: </dict> +//CHECK: <dict> +//CHECK: <key>kind</key><string>control</string> +//CHECK: <key>edges</key> +//CHECK: <array> +//CHECK: <dict> +//CHECK: <key>start</key> +//CHECK: <array> +//CHECK: <dict> +//CHECK: <key>line</key><integer>24</integer> +//CHECK: <key>col</key><integer>5</integer> +//CHECK: <key>file</key><integer>0</integer> +//CHECK: </dict> +//CHECK: <dict> +//CHECK: <key>line</key><integer>24</integer> +//CHECK: <key>col</key><integer>18</integer> +//CHECK: <key>file</key><integer>0</integer> +//CHECK: </dict> +//CHECK: </array> +//CHECK: <key>end</key> +//CHECK: <array> +//CHECK: <dict> +//CHECK: <key>line</key><integer>25</integer> +//CHECK: <key>col</key><integer>5</integer> +//CHECK: <key>file</key><integer>0</integer> +//CHECK: </dict> +//CHECK: <dict> +//CHECK: <key>line</key><integer>25</integer> +//CHECK: <key>col</key><integer>10</integer> +//CHECK: <key>file</key><integer>0</integer> +//CHECK: </dict> +//CHECK: </array> +//CHECK: </dict> +//CHECK: </array> +//CHECK: </dict> +//CHECK: <dict> +//CHECK: <key>kind</key><string>control</string> +//CHECK: <key>edges</key> +//CHECK: <array> +//CHECK: <dict> +//CHECK: <key>start</key> +//CHECK: <array> +//CHECK: <dict> +//CHECK: <key>line</key><integer>25</integer> +//CHECK: <key>col</key><integer>5</integer> +//CHECK: <key>file</key><integer>0</integer> +//CHECK: </dict> +//CHECK: <dict> +//CHECK: <key>line</key><integer>25</integer> +//CHECK: <key>col</key><integer>10</integer> +//CHECK: <key>file</key><integer>0</integer> +//CHECK: </dict> +//CHECK: </array> +//CHECK: <key>end</key> +//CHECK: <array> +//CHECK: <dict> +//CHECK: <key>line</key><integer>25</integer> +//CHECK: <key>col</key><integer>12</integer> +//CHECK: <key>file</key><integer>0</integer> +//CHECK: </dict> +//CHECK: <dict> +//CHECK: <key>line</key><integer>25</integer> +//CHECK: <key>col</key><integer>13</integer> +//CHECK: <key>file</key><integer>0</integer> +//CHECK: </dict> +//CHECK: </array> +//CHECK: </dict> +//CHECK: </array> +//CHECK: </dict> +//CHECK: <dict> +//CHECK: <key>kind</key><string>event</string> +//CHECK: <key>location</key> +//CHECK: <dict> +//CHECK: <key>line</key><integer>25</integer> +//CHECK: <key>col</key><integer>12</integer> +//CHECK: <key>file</key><integer>0</integer> +//CHECK: </dict> +//CHECK: <key>ranges</key> +//CHECK: <array> +//CHECK: <array> +//CHECK: <dict> +//CHECK: <key>line</key><integer>25</integer> +//CHECK: <key>col</key><integer>12</integer> +//CHECK: <key>file</key><integer>0</integer> +//CHECK: </dict> +//CHECK: <dict> +//CHECK: <key>line</key><integer>25</integer> +//CHECK: <key>col</key><integer>13</integer> +//CHECK: <key>file</key><integer>0</integer> +//CHECK: </dict> +//CHECK: </array> +//CHECK: </array> +//CHECK: <key>depth</key><integer>0</integer> +//CHECK: <key>extended_message</key> +//CHECK: <string>The left operand of '+' is a garbage value</string> +//CHECK: <key>message</key> +//CHECK: <string>The left operand of '+' is a garbage value</string> +//CHECK: </dict> +//CHECK: </array> +//CHECK: <key>description</key><string>The left operand of '+' is a garbage value</string> +//CHECK: <key>category</key><string>Logic error</string> +//CHECK: <key>type</key><string>Result of operation is garbage or undefined</string> +//CHECK: <key>issue_context_kind</key><string>function</string> +//CHECK: <key>issue_context</key><string>use</string> +//CHECK: <key>issue_hash</key><integer>7</integer> +//CHECK: <key>location</key> +//CHECK: <dict> +//CHECK: <key>line</key><integer>25</integer> +//CHECK: <key>col</key><integer>12</integer> +//CHECK: <key>file</key><integer>0</integer> +//CHECK: </dict> +//CHECK: </dict> +//CHECK: </array> +//CHECK: </dict> +//CHECK: </plist> |