diff options
author | David Blaikie <dblaikie@gmail.com> | 2013-02-21 01:47:18 +0000 |
---|---|---|
committer | David Blaikie <dblaikie@gmail.com> | 2013-02-21 01:47:18 +0000 |
commit | 66874fb18afbffb8b2ca05576851a64534be3352 (patch) | |
tree | d6391d232c549a7ec1e6bb31a943e468aac589d9 /lib/StaticAnalyzer/Core | |
parent | 65124fe81f61eed98b845c87e3a78a780f3deb11 (diff) |
Use None rather than Optional<T>() where possible.
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@175705 91177308-0d34-0410-b5e6-96231b3b80d8
Diffstat (limited to 'lib/StaticAnalyzer/Core')
-rw-r--r-- | lib/StaticAnalyzer/Core/PathDiagnostic.cpp | 6 | ||||
-rw-r--r-- | lib/StaticAnalyzer/Core/RegionStore.cpp | 14 |
2 files changed, 10 insertions, 10 deletions
diff --git a/lib/StaticAnalyzer/Core/PathDiagnostic.cpp b/lib/StaticAnalyzer/Core/PathDiagnostic.cpp index bbf2db3dde..69a4e2706a 100644 --- a/lib/StaticAnalyzer/Core/PathDiagnostic.cpp +++ b/lib/StaticAnalyzer/Core/PathDiagnostic.cpp @@ -225,7 +225,7 @@ compareControlFlow(const PathDiagnosticControlFlowPiece &X, FullSourceLoc YEL = Y.getEndLocation().asLocation(); if (XEL != YEL) return XEL.isBeforeInTranslationUnitThan(YEL); - return Optional<bool>(); + return None; } static Optional<bool> compareMacro(const PathDiagnosticMacroPiece &X, @@ -283,7 +283,7 @@ static Optional<bool> comparePiece(const PathDiagnosticPiece &X, return compareControlFlow(cast<PathDiagnosticControlFlowPiece>(X), cast<PathDiagnosticControlFlowPiece>(Y)); case clang::ento::PathDiagnosticPiece::Event: - return Optional<bool>(); + return None; case clang::ento::PathDiagnosticPiece::Macro: return compareMacro(cast<PathDiagnosticMacroPiece>(X), cast<PathDiagnosticMacroPiece>(Y)); @@ -302,7 +302,7 @@ static Optional<bool> comparePath(const PathPieces &X, const PathPieces &Y) { if (b.hasValue()) return b.getValue(); } - return Optional<bool>(); + return None; } static bool compare(const PathDiagnostic &X, const PathDiagnostic &Y) { diff --git a/lib/StaticAnalyzer/Core/RegionStore.cpp b/lib/StaticAnalyzer/Core/RegionStore.cpp index 3bd624b18a..09bbcefe43 100644 --- a/lib/StaticAnalyzer/Core/RegionStore.cpp +++ b/lib/StaticAnalyzer/Core/RegionStore.cpp @@ -227,7 +227,7 @@ typedef const RegionBindingsRef& RegionBindingsConstRef; Optional<SVal> RegionBindingsRef::getDirectBinding(const MemRegion *R) const { if (const SVal *V = lookup(R, BindingKey::Direct)) return *V; - return Optional<SVal>(); + return None; } Optional<SVal> RegionBindingsRef::getDefaultBinding(const MemRegion *R) const { @@ -237,7 +237,7 @@ Optional<SVal> RegionBindingsRef::getDefaultBinding(const MemRegion *R) const { return UnknownVal(); if (const SVal *V = lookup(R, BindingKey::Default)) return *V; - return Optional<SVal>(); + return None; } RegionBindingsRef RegionBindingsRef::addBinding(BindingKey K, SVal V) const { @@ -1448,12 +1448,12 @@ RegionStoreManager::getBindingForDerivedDefaultValue(RegionBindingsConstRef B, // Lazy bindings are handled later. if (val.getAs<nonloc::LazyCompoundVal>()) - return Optional<SVal>(); + return None; llvm_unreachable("Unknown default value"); } - return Optional<SVal>(); + return None; } SVal RegionStoreManager::getLazyBinding(const SubRegion *LazyBindingRegion, @@ -1574,11 +1574,11 @@ SVal RegionStoreManager::getBindingForObjCIvar(RegionBindingsConstRef B, static Optional<SVal> getConstValue(SValBuilder &SVB, const VarDecl *VD) { ASTContext &Ctx = SVB.getContext(); if (!VD->getType().isConstQualified()) - return Optional<SVal>(); + return None; const Expr *Init = VD->getInit(); if (!Init) - return Optional<SVal>(); + return None; llvm::APSInt Result; if (Init->EvaluateAsInt(Result, Ctx)) @@ -1588,7 +1588,7 @@ static Optional<SVal> getConstValue(SValBuilder &SVB, const VarDecl *VD) { return SVB.makeNull(); // FIXME: Handle other possible constant expressions. - return Optional<SVal>(); + return None; } SVal RegionStoreManager::getBindingForVar(RegionBindingsConstRef B, |