aboutsummaryrefslogtreecommitdiff
path: root/lib/StaticAnalyzer/Checkers/MallocChecker.cpp
diff options
context:
space:
mode:
authorAnna Zaks <ganna@apple.com>2012-03-01 22:06:06 +0000
committerAnna Zaks <ganna@apple.com>2012-03-01 22:06:06 +0000
commitb3d7275c1a4a9f676af850cd661b56c4ad7ef5c9 (patch)
treeb440cd023ec5d050e060d42b32df306b24d1dccf /lib/StaticAnalyzer/Checkers/MallocChecker.cpp
parentad8de5142a592db1d947e4883b64f63936d5d682 (diff)
[analyzer] Fix a regression introduced in malloc with
attributes, introduced in r151188. + the test to catch it. Thanks to Ahmed Charles for pointing this out. git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@151840 91177308-0d34-0410-b5e6-96231b3b80d8
Diffstat (limited to 'lib/StaticAnalyzer/Checkers/MallocChecker.cpp')
-rw-r--r--lib/StaticAnalyzer/Checkers/MallocChecker.cpp10
1 files changed, 7 insertions, 3 deletions
diff --git a/lib/StaticAnalyzer/Checkers/MallocChecker.cpp b/lib/StaticAnalyzer/Checkers/MallocChecker.cpp
index ae81ad6eda..b74317cc98 100644
--- a/lib/StaticAnalyzer/Checkers/MallocChecker.cpp
+++ b/lib/StaticAnalyzer/Checkers/MallocChecker.cpp
@@ -442,12 +442,16 @@ ProgramStateRef MallocChecker::FreeMemAttr(CheckerContext &C,
if (Att->getModule() != "malloc")
return 0;
+ ProgramStateRef State = C.getState();
+
for (OwnershipAttr::args_iterator I = Att->args_begin(), E = Att->args_end();
I != E; ++I) {
- return FreeMemAux(C, CE, C.getState(), *I,
- Att->getOwnKind() == OwnershipAttr::Holds);
+ ProgramStateRef StateI = FreeMemAux(C, CE, State, *I,
+ Att->getOwnKind() == OwnershipAttr::Holds);
+ if (StateI)
+ State = StateI;
}
- return 0;
+ return State;
}
ProgramStateRef MallocChecker::FreeMemAux(CheckerContext &C,