aboutsummaryrefslogtreecommitdiff
path: root/lib/StaticAnalyzer/Checkers/IvarInvalidationChecker.cpp
diff options
context:
space:
mode:
authorAnna Zaks <ganna@apple.com>2013-01-11 03:52:44 +0000
committerAnna Zaks <ganna@apple.com>2013-01-11 03:52:44 +0000
commit6de7daa60412744bcf168c6c0d521688435fe221 (patch)
tree977b509a3464d95c767985dbaa36c64eb89cf443 /lib/StaticAnalyzer/Checkers/IvarInvalidationChecker.cpp
parentb8f6678bdd54d4dabac416476993343837dd229c (diff)
[analyzer] Rename the warning: state the issue before the hint of how it
can be fixed git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@172170 91177308-0d34-0410-b5e6-96231b3b80d8
Diffstat (limited to 'lib/StaticAnalyzer/Checkers/IvarInvalidationChecker.cpp')
-rw-r--r--lib/StaticAnalyzer/Checkers/IvarInvalidationChecker.cpp11
1 files changed, 5 insertions, 6 deletions
diff --git a/lib/StaticAnalyzer/Checkers/IvarInvalidationChecker.cpp b/lib/StaticAnalyzer/Checkers/IvarInvalidationChecker.cpp
index 4f2a9097b4..9d25ce0364 100644
--- a/lib/StaticAnalyzer/Checkers/IvarInvalidationChecker.cpp
+++ b/lib/StaticAnalyzer/Checkers/IvarInvalidationChecker.cpp
@@ -408,11 +408,10 @@ void IvarInvalidationChecker::checkASTDecl(const ObjCImplementationDecl *ImplD,
if (!Info.needsInvalidation()) {
SmallString<128> sbuf;
llvm::raw_svector_ostream os(sbuf);
- os << "No invalidation method declared in the @interface for "
- << InterfaceD->getName() << "; ";
assert(FirstIvarDecl);
printIvar(os, FirstIvarDecl, IvarToPopertyMap);
- os << "needs to be invalidated";
+ os << "needs to be invalidated; ";
+ os << "No invalidation method is declared for " << InterfaceD->getName();
PathDiagnosticLocation IvarDecLocation =
PathDiagnosticLocation::createBegin(FirstIvarDecl, BR.getSourceManager());
@@ -473,11 +472,11 @@ void IvarInvalidationChecker::checkASTDecl(const ObjCImplementationDecl *ImplD,
if (!AtImplementationContainsAtLeastOneInvalidationMethod) {
SmallString<128> sbuf;
llvm::raw_svector_ostream os(sbuf);
- os << "No invalidation method defined in the @implementation for "
- << InterfaceD->getName() << "; ";
assert(FirstIvarDecl);
printIvar(os, FirstIvarDecl, IvarToPopertyMap);
- os << "needs to be invalidated";
+ os << "needs to be invalidated; ";
+ os << "No invalidation method is defined in the @implementation for "
+ << InterfaceD->getName();
PathDiagnosticLocation IvarDecLocation =
PathDiagnosticLocation::createBegin(FirstIvarDecl,