diff options
author | Rafael Espindola <rafael.espindola@gmail.com> | 2012-03-05 10:54:55 +0000 |
---|---|---|
committer | Rafael Espindola <rafael.espindola@gmail.com> | 2012-03-05 10:54:55 +0000 |
commit | 234fe654a3dd2888be42ae5db34db96c5c2c4ba3 (patch) | |
tree | 2e6ae67d1dfb3dbce908f2e7bb58a4acf08192ac /lib/Sema/SemaTemplateInstantiateDecl.cpp | |
parent | b3c312ce4d94a037a83ba6df6650b0317b15edd1 (diff) |
Fix a small difference in sema and codegen views of what needs to be output.
In the included testcase, soma thinks that we already have a definition after we
see the out of line decl. Codegen puts it in a deferred list, to be output if
a use is seen. This would break when we saw an explicit template instantiation
definition, since codegen would not be notified.
This patch adds a method to the consumer interface so that soma can notify
codegen that this decl is now required.
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@152024 91177308-0d34-0410-b5e6-96231b3b80d8
Diffstat (limited to 'lib/Sema/SemaTemplateInstantiateDecl.cpp')
-rw-r--r-- | lib/Sema/SemaTemplateInstantiateDecl.cpp | 12 |
1 files changed, 8 insertions, 4 deletions
diff --git a/lib/Sema/SemaTemplateInstantiateDecl.cpp b/lib/Sema/SemaTemplateInstantiateDecl.cpp index d491dfc51e..4633db737a 100644 --- a/lib/Sema/SemaTemplateInstantiateDecl.cpp +++ b/lib/Sema/SemaTemplateInstantiateDecl.cpp @@ -2596,21 +2596,25 @@ void Sema::InstantiateStaticDataMemberDefinition( return; } + TemplateSpecializationKind TSK = Var->getTemplateSpecializationKind(); + // Never instantiate an explicit specialization. - if (Var->getTemplateSpecializationKind() == TSK_ExplicitSpecialization) + if (TSK == TSK_ExplicitSpecialization) return; // C++0x [temp.explicit]p9: // Except for inline functions, other explicit instantiation declarations // have the effect of suppressing the implicit instantiation of the entity // to which they refer. - if (Var->getTemplateSpecializationKind() - == TSK_ExplicitInstantiationDeclaration) + if (TSK == TSK_ExplicitInstantiationDeclaration) return; // If we already have a definition, we're done. - if (Var->getDefinition()) + if (Var->getDefinition()) { + if (TSK == TSK_ExplicitInstantiationDefinition) + Consumer.MarkVarRequired(Var); return; + } InstantiatingTemplate Inst(*this, PointOfInstantiation, Var); if (Inst) |