diff options
author | David Majnemer <david.majnemer@gmail.com> | 2011-07-22 21:09:04 +0000 |
---|---|---|
committer | David Majnemer <david.majnemer@gmail.com> | 2011-07-22 21:09:04 +0000 |
commit | 0ad92314852c4349685946997ca0967a32ccdb99 (patch) | |
tree | 7c5dd139bd5fc5de3047d91496eff89b1c32c823 /lib/Sema/SemaOverload.cpp | |
parent | 9461fccd05bde8458710ba367be10b6e4efe2ec7 (diff) |
kill a FIXME in IsIntegralPromotion
IsIntegralPromotion should consider the signedness of FromType when
calculating promotions. This, as of now, cannot be exercised on any
platform so there is no corresponding test.
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@135803 91177308-0d34-0410-b5e6-96231b3b80d8
Diffstat (limited to 'lib/Sema/SemaOverload.cpp')
-rw-r--r-- | lib/Sema/SemaOverload.cpp | 5 |
1 files changed, 1 insertions, 4 deletions
diff --git a/lib/Sema/SemaOverload.cpp b/lib/Sema/SemaOverload.cpp index 969998eaa0..793e427629 100644 --- a/lib/Sema/SemaOverload.cpp +++ b/lib/Sema/SemaOverload.cpp @@ -1392,12 +1392,9 @@ bool Sema::IsIntegralPromotion(Expr *From, QualType FromType, QualType ToType) { ToType->isIntegerType()) { // Determine whether the type we're converting from is signed or // unsigned. - bool FromIsSigned; + bool FromIsSigned = FromType->isSignedIntegerType(); uint64_t FromSize = Context.getTypeSize(FromType); - // FIXME: Is wchar_t signed or unsigned? We assume it's signed for now. - FromIsSigned = true; - // The types we'll try to promote to, in the appropriate // order. Try each of these types. QualType PromoteTypes[6] = { |