diff options
| author | John McCall <rjmccall@apple.com> | 2010-08-02 21:13:48 +0000 |
|---|---|---|
| committer | John McCall <rjmccall@apple.com> | 2010-08-02 21:13:48 +0000 |
| commit | 4204f07fc8bffe6d320b2de95fea274ccf37a17b (patch) | |
| tree | 90f5c06c89e2673b40fd7352a497c661c4901d5c /lib/Sema/SemaDeclCXX.cpp | |
| parent | 73dfa3d30ab19d358b782c201201fa2a2dcf51a6 (diff) | |
Further adjustments to -Wglobal-constructors; works for references and direct
initializations now.
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@110063 91177308-0d34-0410-b5e6-96231b3b80d8
Diffstat (limited to 'lib/Sema/SemaDeclCXX.cpp')
| -rw-r--r-- | lib/Sema/SemaDeclCXX.cpp | 8 |
1 files changed, 8 insertions, 0 deletions
diff --git a/lib/Sema/SemaDeclCXX.cpp b/lib/Sema/SemaDeclCXX.cpp index a0bc5840cd..5677b5c993 100644 --- a/lib/Sema/SemaDeclCXX.cpp +++ b/lib/Sema/SemaDeclCXX.cpp @@ -5461,6 +5461,14 @@ void Sema::AddCXXDirectInitializerToDecl(DeclPtrTy Dcl, VDecl->setInit(Result.takeAs<Expr>()); VDecl->setCXXDirectInitializer(true); + if (!VDecl->isInvalidDecl() && + !VDecl->getDeclContext()->isDependentContext() && + VDecl->hasGlobalStorage() && + !VDecl->getInit()->isConstantInitializer(Context, + VDecl->getType()->isReferenceType())) + Diag(VDecl->getLocation(), diag::warn_global_constructor) + << VDecl->getInit()->getSourceRange(); + if (const RecordType *Record = VDecl->getType()->getAs<RecordType>()) FinalizeVarWithDestructor(VDecl, Record); } |