diff options
| author | Manuel Klimek <klimek@google.com> | 2012-12-12 13:26:54 +0000 |
|---|---|---|
| committer | Manuel Klimek <klimek@google.com> | 2012-12-12 13:26:54 +0000 |
| commit | acaf110ec9f2622f76f32c23fd0c2488952bdd21 (patch) | |
| tree | b0cda6e2ab84d5d3e0d27f6cf81b40344740cec8 /lib/Sema/SemaDecl.cpp | |
| parent | 04ee66e1fee44e72ee57845c1405a7f498a9daf7 (diff) | |
Speeds up parsing of global declarations in cases where the warning
is switched of by about 0.8% (tested with int i<N>).
Additionally, this puts computing the diagnostic class into the hot
path more when parsing, in preparation for upcoming optimizations
in this area.
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@169976 91177308-0d34-0410-b5e6-96231b3b80d8
Diffstat (limited to 'lib/Sema/SemaDecl.cpp')
| -rw-r--r-- | lib/Sema/SemaDecl.cpp | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/lib/Sema/SemaDecl.cpp b/lib/Sema/SemaDecl.cpp index aa0b41bc7a..10e871a630 100644 --- a/lib/Sema/SemaDecl.cpp +++ b/lib/Sema/SemaDecl.cpp @@ -7233,7 +7233,10 @@ void Sema::CheckCompleteVariableDeclaration(VarDecl *var) { } if (var->isThisDeclarationADefinition() && - var->getLinkage() == ExternalLinkage) { + var->getLinkage() == ExternalLinkage && + getDiagnostics().getDiagnosticLevel( + diag::warn_missing_variable_declarations, + var->getLocation())) { // Find a previous declaration that's not a definition. VarDecl *prev = var->getPreviousDecl(); while (prev && prev->isThisDeclarationADefinition()) |