diff options
author | Chris Lattner <sabre@nondot.org> | 2009-04-02 04:16:50 +0000 |
---|---|---|
committer | Chris Lattner <sabre@nondot.org> | 2009-04-02 04:16:50 +0000 |
commit | 97144fc41a9419bf6d74fc9450e8ef3f6e11f7e0 (patch) | |
tree | fa4999c1dd962098ab138210b5268e02b340acbc /lib/Parse/ParseTemplate.cpp | |
parent | 0ddaff3a558cca0d1157c3f63e3ad82b72cf625a (diff) |
fix a FIXME, providing accurate source range info for DeclStmt's. The end
of the range is now the ';' location. For something like this:
$ cat t2.c
#define bool int
void f(int x, int y) {
bool b = !x && y;
}
We used to produce:
$ clang-cc t2.c -ast-dump
typedef char *__builtin_va_list;
void f(int x, int y)
(CompoundStmt 0x2201f10 <t2.c:3:22, line:5:1>
(DeclStmt 0x2201ef0 <line:2:14> <----
0x2201a20 "int b =
(BinaryOperator 0x2201ed0 <line:4:10, col:16> 'int' '&&'
(UnaryOperator 0x2201e90 <col:10, col:11> 'int' prefix '!'
(DeclRefExpr 0x2201c90 <col:11> 'int' ParmVar='x' 0x2201a50))
(DeclRefExpr 0x2201eb0 <col:16> 'int' ParmVar='y' 0x2201e10))")
Now we produce:
$ clang-cc t2.c -ast-dump
typedef char *__builtin_va_list;
void f(int x, int y)
(CompoundStmt 0x2201f10 <t2.c:3:22, line:5:1>
(DeclStmt 0x2201ef0 <line:2:14, line:4:17> <------
0x2201a20 "int b =
(BinaryOperator 0x2201ed0 <col:10, col:16> 'int' '&&'
(UnaryOperator 0x2201e90 <col:10, col:11> 'int' prefix '!'
(DeclRefExpr 0x2201c90 <col:11> 'int' ParmVar='x' 0x2201a50))
(DeclRefExpr 0x2201eb0 <col:16> 'int' ParmVar='y' 0x2201e10))")
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@68288 91177308-0d34-0410-b5e6-96231b3b80d8
Diffstat (limited to 'lib/Parse/ParseTemplate.cpp')
-rw-r--r-- | lib/Parse/ParseTemplate.cpp | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/lib/Parse/ParseTemplate.cpp b/lib/Parse/ParseTemplate.cpp index 0f9bcd2219..d38df93ace 100644 --- a/lib/Parse/ParseTemplate.cpp +++ b/lib/Parse/ParseTemplate.cpp @@ -35,6 +35,7 @@ using namespace clang; /// 'template' '<' '>' declaration Parser::DeclPtrTy Parser::ParseTemplateDeclarationOrSpecialization(unsigned Context, + SourceLocation &DeclEnd, AccessSpecifier AS) { assert((Tok.is(tok::kw_export) || Tok.is(tok::kw_template)) && "Token does not start a template declaration."); @@ -99,6 +100,9 @@ Parser::ParseTemplateDeclarationOrSpecialization(unsigned Context, // FIXME: Converting DeclGroupPtr to DeclPtr like this is an insanely gruesome // hack, will bring up on cfe-dev. DeclGroupPtrTy DG = ParseDeclarationOrFunctionDefinition(&ParamLists, AS); + // FIXME: Should be ';' location not the token after it. Resolve with above + // fixmes. + DeclEnd = Tok.getLocation(); return DeclPtrTy::make(DG.get()); } |