diff options
author | Douglas Gregor <dgregor@apple.com> | 2009-05-28 23:31:59 +0000 |
---|---|---|
committer | Douglas Gregor <dgregor@apple.com> | 2009-05-28 23:31:59 +0000 |
commit | 402abb55fc2e0cdda5fb1ac90009b1f5f6774906 (patch) | |
tree | 3c379d93e527baaa9a8cc7184a92f80b8f9762da /lib/Parse/DeclSpec.cpp | |
parent | 2dce5f8a99b5c48f1287ff3941288ca6f7fde2de (diff) |
When we parse a tag specifier, keep track of whether that tag
specifier resulted in the creation of a new TagDecl node, which
happens either when the tag specifier was a definition or when the tag
specifier was the first declaration of that tag type. This information
has several uses, the first of which is implemented in this commit:
1) In C++, one is not allowed to define tag types within a type
specifier (e.g., static_cast<struct S { int x; } *>(0) is
ill-formed) or within the result or parameter types of a
function. We now diagnose this.
2) We can extend DeclGroups to contain information about any tags
that are declared/defined within the declaration specifiers of a
variable, e.g.,
struct Point { int x, y, z; } p;
This will help improve AST printing and template instantiation,
among other things.
3) For C99, we can keep track of whether a tag type is defined
within the type of a parameter, to properly cope with cases like,
e.g.,
int bar(struct T2 { int x; } y) {
struct T2 z;
}
We can also do similar things wherever there is a type specifier,
e.g., to keep track of where the definition of S occurs in this
legal C99 code:
(struct S { int x, y; } *)0
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@72555 91177308-0d34-0410-b5e6-96231b3b80d8
Diffstat (limited to 'lib/Parse/DeclSpec.cpp')
-rw-r--r-- | lib/Parse/DeclSpec.cpp | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/lib/Parse/DeclSpec.cpp b/lib/Parse/DeclSpec.cpp index e592deecd0..2a765d2124 100644 --- a/lib/Parse/DeclSpec.cpp +++ b/lib/Parse/DeclSpec.cpp @@ -241,12 +241,14 @@ bool DeclSpec::SetTypeSpecSign(TSS S, SourceLocation Loc, } bool DeclSpec::SetTypeSpecType(TST T, SourceLocation Loc, - const char *&PrevSpec, void *Rep) { + const char *&PrevSpec, void *Rep, + bool Owned) { if (TypeSpecType != TST_unspecified) return BadSpecifier((TST)TypeSpecType, PrevSpec); TypeSpecType = T; TypeRep = Rep; TSTLoc = Loc; + TypeSpecOwned = Owned; return false; } |