diff options
| author | Chris Lattner <sabre@nondot.org> | 2008-05-04 18:36:18 +0000 |
|---|---|---|
| committer | Chris Lattner <sabre@nondot.org> | 2008-05-04 18:36:18 +0000 |
| commit | 9189156429c06eea3f75cb01646e2afd78000f39 (patch) | |
| tree | 0b835404f849b1e47a67897759d5070347eb20f3 /lib/Lex/PPExpressions.cpp | |
| parent | d5214b22cccbc30ac2e07c44ef91e498f2046652 (diff) | |
Fix the rest of PR2279:
a) correct rejection of ',' in pp expressions.
b) the precedence of ',' was wrong w.r.t. ?:.
Thanks again to Neil for finding these and providing testcases.
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@50625 91177308-0d34-0410-b5e6-96231b3b80d8
Diffstat (limited to 'lib/Lex/PPExpressions.cpp')
| -rw-r--r-- | lib/Lex/PPExpressions.cpp | 11 |
1 files changed, 7 insertions, 4 deletions
diff --git a/lib/Lex/PPExpressions.cpp b/lib/Lex/PPExpressions.cpp index 6343a3c098..3c0bf5c59c 100644 --- a/lib/Lex/PPExpressions.cpp +++ b/lib/Lex/PPExpressions.cpp @@ -328,9 +328,9 @@ static unsigned getPrecedence(tok::TokenKind Kind) { case tok::pipe: return 7; case tok::ampamp: return 6; case tok::pipepipe: return 5; - case tok::question: return 4; - case tok::colon: return 3; - case tok::comma: return 2; + case tok::comma: return 4; + case tok::question: return 3; + case tok::colon: return 2; case tok::r_paren: return 0; // Lowest priority, end of expr. case tok::eom: return 0; // Lowest priority, end of macro. } @@ -543,7 +543,10 @@ static bool EvaluateDirectiveSubExpr(llvm::APSInt &LHS, unsigned MinPrec, Res.setIsUnsigned(false); // C99 6.5.14p3, result is always int (signed) break; case tok::comma: - PP.Diag(OpToken, diag::ext_pp_comma_expr); + // Comma is invalid in pp expressions in c89/c++ mode, but is valid in C99 + // if not being evaluated. + if (!PP.getLangOptions().C99 || ValueLive) + PP.Diag(OpToken, diag::ext_pp_comma_expr); Res = RHS; // LHS = LHS,RHS -> RHS. break; case tok::question: { |