diff options
author | Douglas Gregor <dgregor@apple.com> | 2010-11-11 00:39:14 +0000 |
---|---|---|
committer | Douglas Gregor <dgregor@apple.com> | 2010-11-11 00:39:14 +0000 |
commit | e47be3e9682e82da15059006f43c7f3c021e4fff (patch) | |
tree | 949de514619f85922014fd05a870d393849d9534 /lib/Frontend/CompilerInstance.cpp | |
parent | e27e9d673346056e6ff7dca1d7fb1d75dfd42956 (diff) |
Improve ASTUnit's capture of diagnostics so that the
diagnostic-capturing client lives as long as the ASTUnit itself
does. Otherwise, we can end up with crashes when we get a diagnostic
outside of parsing/code completion. The circumstances under which this
happen are really hard to reproduce, because a file needs to change
from under us.
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@118751 91177308-0d34-0410-b5e6-96231b3b80d8
Diffstat (limited to 'lib/Frontend/CompilerInstance.cpp')
-rw-r--r-- | lib/Frontend/CompilerInstance.cpp | 14 |
1 files changed, 9 insertions, 5 deletions
diff --git a/lib/Frontend/CompilerInstance.cpp b/lib/Frontend/CompilerInstance.cpp index c5e5d7f90a..7cfcd1c419 100644 --- a/lib/Frontend/CompilerInstance.cpp +++ b/lib/Frontend/CompilerInstance.cpp @@ -113,19 +113,23 @@ static void SetUpBuildDumpLog(const DiagnosticOptions &DiagOpts, Diags.setClient(new ChainedDiagnosticClient(Diags.takeClient(), Logger)); } -void CompilerInstance::createDiagnostics(int Argc, const char* const *Argv) { - Diagnostics = createDiagnostics(getDiagnosticOpts(), Argc, Argv); +void CompilerInstance::createDiagnostics(int Argc, const char* const *Argv, + DiagnosticClient *Client) { + Diagnostics = createDiagnostics(getDiagnosticOpts(), Argc, Argv, Client); } llvm::IntrusiveRefCntPtr<Diagnostic> CompilerInstance::createDiagnostics(const DiagnosticOptions &Opts, - int Argc, const char* const *Argv) { + int Argc, const char* const *Argv, + DiagnosticClient *Client) { llvm::IntrusiveRefCntPtr<Diagnostic> Diags(new Diagnostic()); // Create the diagnostic client for reporting errors or for // implementing -verify. - llvm::OwningPtr<DiagnosticClient> DiagClient; - Diags->setClient(new TextDiagnosticPrinter(llvm::errs(), Opts)); + if (Client) + Diags->setClient(Client); + else + Diags->setClient(new TextDiagnosticPrinter(llvm::errs(), Opts)); // Chain in -verify checker, if requested. if (Opts.VerifyDiagnostics) |